Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce mutable shared params for benchmarks in pallet gear #1121

Closed
clearloop opened this issue Jun 28, 2022 · 1 comment
Closed

Introduce mutable shared params for benchmarks in pallet gear #1121

clearloop opened this issue Jun 28, 2022 · 1 comment
Assignees
@clearloop
Labels
C2-refactoring Refactoring proposal D5-tooling Helper tools and utilities P2-sometimesoon Medium priority Q1-easy

Comments

@clearloop
Copy link
Contributor

btw, you're right that changing this incoming params hurtful, couldn't it be wrapped into some other function, which will change only required params, cause most of them unchangeable from bench to bench

Originally posted by @breathx in #1063 (comment)
@clearloop clearloop self-assigned this Jun 28, 2022
@breathx breathx added P2-sometimesoon Medium priority C2-refactoring Refactoring proposal D5-tooling Helper tools and utilities Q1-easy labels Jul 18, 2022
@breathx
Copy link
Member

breathx commented Sep 5, 2022

Seems useless after #1211

@breathx breathx closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clearloop clearloop

Labels
C2-refactoring Refactoring proposal D5-tooling Helper tools and utilities P2-sometimesoon Medium priority Q1-easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clearloop @breathx