Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize empty functions #1182

Closed
gshep opened this issue Jul 14, 2022 · 0 comments
Closed

Optimize empty functions #1182

gshep opened this issue Jul 14, 2022 · 0 comments
Assignees
Labels
C2-refactoring Refactoring proposal D1-core Gear Core P2-sometimesoon Medium priority Q2-moderate

Comments

@gshep
Copy link
Member

gshep commented Jul 14, 2022

File Location(s)

No response

Proposal

To optimise with empty functions:
If we try to init program, where init export doesn't exist, we can just skip try to load pages and create env instance. We can check if program contains given export by the code on which program depend (or to avoid reading code, paste gear exports in program instance also), for more details see #1085.

Extracted from #1088

@gshep gshep added D1-core Gear Core C2-refactoring Refactoring proposal labels Jul 14, 2022
@gshep gshep self-assigned this Jul 14, 2022
@shamilsan shamilsan changed the title Optiomize empty functions Optimize empty functions Jul 14, 2022
@gshep gshep closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C2-refactoring Refactoring proposal D1-core Gear Core P2-sometimesoon Medium priority Q2-moderate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants