Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 7 ➡️ 8 #414

Merged
merged 18 commits into from
Jan 29, 2024
Merged

Merge 7 ➡️ 8 #414

merged 18 commits into from
Jan 29, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Jan 26, 2024

➡️ Forward port

Port gz-sensors7 to gz-sensors8

Branch comparison: gz-sensors8...gz-sensors7

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

traversaro and others added 17 commits June 13, 2023 11:32
Signed-off-by: Silvio Traversaro <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
…383)


---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Co-authored-by: Aditya Pande <[email protected]>
Merge ign-sensors3 ➡️  ign-sensors6
* Use on `push` only on stable branches to avoid duplicate runs
* Update project automation

Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-sensors3 ➡️  ign-sensors6

Signed-off-by: Michael Carroll <[email protected]>
…409)

This is to help migration to newer versions of Gazebo and allows users
to replace ignition_frame_id in their SDF files while still in Fortress.

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-sensors3 ➡️  ign-sensors6
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Merge ign-sensors6 ➡️  gz-sensors7
@caguero caguero requested a review from iche033 as a code owner January 26, 2024 18:18
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 26, 2024
@@ -8,7 +8,7 @@ jobs:
name: Ubuntu Jammy CI
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be more changes to this file:

on:
  pull_request:
  push:
    branches:
      - 'ign-sensors[0-9]'
      - 'gz-sensors[0-9]?'
      - 'main'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added and force-pushed

@iche033
Copy link
Contributor

iche033 commented Jan 27, 2024

fixed UNIT_Sensor_TEST by removing the test for ignition_frame_id as it's no longer supported in Harmonic (replaced by gz_frame_id)

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d522779) 72.78% compared to head (a1e068e) 72.77%.
Report is 1 commits behind head on gz-sensors8.

Additional details and impacted files
@@               Coverage Diff               @@
##           gz-sensors8     #414      +/-   ##
===============================================
- Coverage        72.78%   72.77%   -0.02%     
===============================================
  Files               36       36              
  Lines             4972     4980       +8     
===============================================
+ Hits              3619     3624       +5     
- Misses            1353     1356       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit 403fb63 into gz-sensors8 Jan 29, 2024
9 of 10 checks passed
@iche033 iche033 deleted the 7_to_8 branch January 29, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants