Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Rendering tests have been failing on Jammy github actions for a while. This PR fixes the tests and we should now get a green CI.
It was found that all rendering tests segfault on exit, caused by destructor of rendering objects. The changes in this PR fix the test by cleaning up these pointers. Side note: tests are only failing on Jammy github actions and not on other platforms. I'm also not able to reproduce the failing tests locally. Fixes should also be done on the gz-rendering side to make sure objects can destroyed safely when going out of scope.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.