Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering tests on Jammy #324

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix rendering tests on Jammy #324

merged 1 commit into from
Feb 23, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 23, 2023

🦟 Bug fix

Summary

Rendering tests have been failing on Jammy github actions for a while. This PR fixes the tests and we should now get a green CI.

It was found that all rendering tests segfault on exit, caused by destructor of rendering objects. The changes in this PR fix the test by cleaning up these pointers. Side note: tests are only failing on Jammy github actions and not on other platforms. I'm also not able to reproduce the failing tests locally. Fixes should also be done on the gz-rendering side to make sure objects can destroyed safely when going out of scope.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #324 (ba9a263) into ign-sensors6 (d2dff1a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ba9a263 differs from pull request most recent head 280b5d6. Consider uploading reports for the commit 280b5d6 to get more accurate results

@@              Coverage Diff              @@
##           ign-sensors6     #324   +/-   ##
=============================================
  Coverage         73.76%   73.76%           
=============================================
  Files                34       34           
  Lines              3510     3510           
=============================================
  Hits               2589     2589           
  Misses              921      921           
Impacted Files Coverage Δ
src/RenderingSensor.cc 95.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit e03feb1 into ign-sensors6 Feb 23, 2023
@ahcorde ahcorde deleted the fix_jammy_tests branch February 23, 2023 10:57
This was referenced May 24, 2023
scpeters pushed a commit that referenced this pull request Oct 16, 2023
scpeters pushed a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants