Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup resources in CameraSensor destructor #340

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 5, 2023

🦟 Bug fix

Summary

Add a call to make sure we destroy the rendering camera object in destructor

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (gz-sensors7@e19d8c2). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 8adcd18 differs from pull request most recent head d96d7ac. Consider uploading reports for the commit d96d7ac to get more accurate results

@@              Coverage Diff               @@
##             gz-sensors7     #340   +/-   ##
==============================================
  Coverage               ?   70.02%           
==============================================
  Files                  ?       36           
  Lines                  ?     3926           
  Branches               ?        0           
==============================================
  Hits                   ?     2749           
  Misses                 ?     1177           
  Partials               ?        0           
Impacted Files Coverage Δ
src/CameraSensor.cc 80.68% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 merged commit d412d9d into gz-sensors7 Apr 7, 2023
@iche033 iche033 deleted the destroy_camera branch April 7, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants