Forward port 3 to 6 #313
Merged
Forward port 3 to 6 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate headers Signed-off-by: methylDragon <[email protected]> * Add redirection headers Signed-off-by: methylDragon <[email protected]> * Migrate include statements Signed-off-by: methylDragon <[email protected]> * Leave ignition as primary in headers to fix ABI Signed-off-by: methylDragon <[email protected]> * Update ignition names Signed-off-by: Nate Koenig <[email protected]> * tweaks Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: methylDragon <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
iche033
added
the
needs upstream release
7 tasks
|
@osrf-jenkins run tests please |
iche033
removed
the
needs upstream release
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #313 +/- ##
=============================================
Coverage 73.76% 73.76%
=============================================
Files 34 34
Lines 3510 3510
=============================================
Hits 2589 2589
Misses 921 921
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
A few Jammy integration tests failing. Is this expected currently? |
|
yes the rendering tests have been failing on Ubuntu Jammy github actions for a while. Haven't had the chance to figure out why yet. |
Signed-off-by: Ian Chen <[email protected]>
iche033
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-sensors3 to ign-sensors6
Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)