Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Region3 Python interface #450

Merged
merged 11 commits into from
Jul 14, 2022
Merged

Added Region3 Python interface #450

merged 11 commits into from
Jul 14, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 4, 2022 •
edited
Loading

Signed-off-by: ahcorde [email protected]

🎉 New feature

Closes #392
Depends on #449

Summary

Added Region3 Python interface

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

hidmic and others added 8 commits July 4, 2022 09:51
@hidmic @ahcorde
Add Interval class (#388)
f01c06f 
Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic @ahcorde
Add Region3 class (#390)
1b84ea1 
Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic @chapulina @ahcorde
Add Polynomial3 class (#393)
519e794 
Signed-off-by: Michel Hidalgo <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@hidmic @chapulina @ahcorde
Add AdditivelySeparableScalarField3 class (#397)
6a6cbd4 
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@hidmic @ahcorde
Fix unsafe globals in Interval and Region3 (#396)
17e8eff 
Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic @ahcorde
Add PiecewiseScalarField3 class (#398)
5bd8576 
Signed-off-by: Michel Hidalgo <[email protected]>
@ahcorde
Added IntervalPython interface
43188b6 
Signed-off-by: Alejandro Hernández <[email protected]>
@ahcorde
Added Region3 Python interface
23f7250 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde self-assigned this Jul 4, 2022
@ahcorde
make linters happy
a822f55 
Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Jul 5, 2022 •
edited
Loading

Codecov Report

Merging #450 (c38c7b8) into ign-math6 (407afa6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ign-math6     #450   +/-   ##
==========================================
  Coverage      99.68%   99.68%           
==========================================
  Files             73       73           
  Lines           6901     6901           
==========================================
  Hits            6879     6879           
  Misses            22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407afa6...c38c7b8. Read the comment docs.

@ahcorde ahcorde added 🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress labels Jul 5, 2022
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Jul 5, 2022
Base automatically changed from ahcorde/python/interval to ign-math6 July 11, 2022 07:27
@ahcorde ahcorde merged commit 1e1988d into ign-math6 Jul 14, 2022
@ahcorde ahcorde deleted the ahcorde/python/region3 branch July 14, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapande-1995 adityapande-1995 adityapande-1995 approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

@ahcorde ahcorde

Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress scripting Scripting interfaces to Ignition
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Region3 class Python wrapper
4 participants
@ahcorde @adityapande-1995 @chapulina @hidmic