-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Polynomial3 class #393
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
@chapulina PTAL! |
Codecov Report
@@ Coverage Diff @@
## main #393 +/- ##
=======================================
Coverage 99.72% 99.73%
=======================================
Files 67 68 +1
Lines 6219 6314 +95
=======================================
+ Hits 6202 6297 +95
Misses 17 17
Continue to review full report at Codecov.
|
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
79d493c
to
4d8d4b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating, LGTM!
Signed-off-by: Michel Hidalgo <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
🎉 New feature
Summary
Split from #387. This PR introduces a Polynomial3 class to cubic polynomials with real coefficients.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.