-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PiecewiseScalarField3 class #398
Add PiecewiseScalarField3 class #398
Conversation
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 69 70 +1
Lines 6353 6406 +53
=======================================
+ Hits 6336 6389 +53
Misses 17 17
Continue to review full report at Codecov.
|
Signed-off-by: Michel Hidalgo <[email protected]>
d17cd9b
to
ec218a4
Compare
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments
Signed-off-by: Michel Hidalgo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments!
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
🎉 New feature
Summary
Split from #387. This PR introduces a
PiecewiseScalarField3
class to represent a scalar field in R^3 defined on a per region basis.Depends on #397 for testing.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.