Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PiecewiseScalarField3 class #398

Merged
merged 7 commits into from
Apr 1, 2022

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Mar 25, 2022

🎉 New feature

Summary

Split from #387. This PR introduces a PiecewiseScalarField3 class to represent a scalar field in R^3 defined on a per region basis.

Depends on #397 for testing.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@hidmic hidmic added the MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv label Mar 25, 2022
@hidmic hidmic requested a review from chapulina March 25, 2022 20:40
@hidmic hidmic requested a review from scpeters as a code owner March 25, 2022 20:40
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #398 (7901eb7) into main (120806b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          69       70    +1     
  Lines        6353     6406   +53     
=======================================
+ Hits         6336     6389   +53     
  Misses         17       17           
Impacted Files Coverage Δ
include/ignition/math/PiecewiseScalarField3.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120806b...7901eb7. Read the comment docs.

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic hidmic force-pushed the add-piecewise-scalar-field3-class branch from d17cd9b to ec218a4 Compare March 30, 2022 11:12
@hidmic hidmic mentioned this pull request Mar 30, 2022
39 tasks
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments

include/ignition/math/PiecewiseScalarField3.hh Outdated Show resolved Hide resolved
include/ignition/math/PiecewiseScalarField3.hh Outdated Show resolved Hide resolved
include/ignition/math/PiecewiseScalarField3.hh Outdated Show resolved Hide resolved
include/ignition/math/PiecewiseScalarField3.hh Outdated Show resolved Hide resolved
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments!

@chapulina chapulina merged commit 3a2147c into gazebosim:main Apr 1, 2022
@hidmic hidmic deleted the add-piecewise-scalar-field3-class branch April 1, 2022 16:29
ahcorde pushed a commit that referenced this pull request Jul 4, 2022
chapulina pushed a commit that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants