Fix pybind11 issues with macOS #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
github-actions
bot
added
Gazebo 1️1️
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #361 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6380 6380
==========================================
Hits 6358 6358
Misses 22 22
Continue to review full report at Codecov.
|
…ch/math_scripting
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
ahcorde
approved these changes
Jan 26, 2022
j-rivero
approved these changes
Jan 26, 2022
chapulina
approved these changes
Jan 26, 2022
scpeters
added a commit
to scpeters/ign-math
that referenced
this pull request
Feb 25, 2022
Originally from gazebosim#361. Signed-off-by: Steve Peters <[email protected]>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a test failure and compiler error when running the pybind11 tests on macOS. This pull request has a matching branch name with osrf/homebrew-simulation#1793, so the CI is using
pybind11and is now clean.