FindIgnOGRE2: exclude ogre versions different than 2.x #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
github-actions
bot
added
Gazebo 1️1️
iche033
approved these changes
Mar 31, 2022
hidmic
reviewed
Apr 1, 2022
| if (${IgnOGRE2_FIND_VERSION_MAJOR}) | ||
| if (${IgnOGRE2_FIND_VERSION_MAJOR} VERSION_LESS "2") | ||
| if (${IgnOGRE2_FIND_VERSION_MAJOR} VERSION_LESS "2" OR | ||
| (${IgnOGRE2_FIND_VERSION_MAJOR} VERSION_GREATER_EQUAL "3") |
There was a problem hiding this comment.
@j-rivero the leading open parenthesis on this line shouldn't be there.
There was a problem hiding this comment.
umm the cmake linter was broken in a pip upgrade, bad bussiness.
hidmic
added a commit
that referenced
this pull request
Apr 1, 2022
Follow-up after #219 Signed-off-by: Michel Hidalgo <[email protected]>
j-rivero
pushed a commit
that referenced
this pull request
Apr 1, 2022
Follow-up after #219 Signed-off-by: Michel Hidalgo <[email protected]>
harshmahesheka
pushed a commit
to harshmahesheka/ign-cmake
that referenced
this pull request
Apr 5, 2022
Signed-off-by: Jose Luis Rivero <[email protected]> Signed-off-by: Harsh Mahesheka <[email protected]>
harshmahesheka
pushed a commit
to harshmahesheka/ign-cmake
that referenced
this pull request
Apr 5, 2022
Follow-up after gazebosim#219 Signed-off-by: Michel Hidalgo <[email protected]> Signed-off-by: Harsh Mahesheka <[email protected]>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #205