Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FindIgnOGRE2.cmake #221

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Apr 1, 2022

🦟 Bug fix

Fixes a regression introduced in #219

Summary

A minor bugfix for a typo in #219. How did this manage to get past CI?

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Follow-up after #219

Signed-off-by: Michel Hidalgo <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Apr 1, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Apr 1, 2022
@j-rivero
Copy link
Contributor

j-rivero commented Apr 1, 2022

Fixes a regression introduced in #219

Thanks for the fix!

@j-rivero j-rivero merged commit e7e2c53 into ign-cmake2 Apr 1, 2022
@j-rivero j-rivero deleted the hidmic/fix-ign-ogre2-cmake-module branch April 1, 2022 19:14
harshmahesheka pushed a commit to harshmahesheka/ign-cmake that referenced this pull request Apr 5, 2022
Follow-up after gazebosim#219

Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Harsh Mahesheka <[email protected]>
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants