Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindIgnOGRE2: exclude ogre versions different than 2.x #219

Merged
merged 1 commit into from
Apr 1, 2022
Merged

FindIgnOGRE2: exclude ogre versions different than 2.x #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmake/FindIgnOGRE2.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,13 @@
# VERSION 2.2.0
# COMPONENTS HlmsPbs HlmsUnlit Overlay)

# sanity check
# Sanity check: exclude OGRE1 project releasing versions in two ways:
# - Legacy in from using 1.x.y until 1.12.y series
# - Modern versions using X.Y.Z starting with 13.y.z
# Reduce valid versions to 2.x series
if (${IgnOGRE2_FIND_VERSION_MAJOR})
if (${IgnOGRE2_FIND_VERSION_MAJOR} VERSION_LESS "2")
if (${IgnOGRE2_FIND_VERSION_MAJOR} VERSION_LESS "2" OR
(${IgnOGRE2_FIND_VERSION_MAJOR} VERSION_GREATER_EQUAL "3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-rivero the leading open parenthesis on this line shouldn't be there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm the cmake linter was broken in a pip upgrade, bad bussiness.

set (OGRE2_FOUND false)
return()
endif()
Expand Down