Add Integration tests #618

rkjakeer · 2021-06-02T18:52:04Z

What this PR does / why we need it:
This PR adds a set of common Integration test cases as a framework for all machine-controller-manager-provider-{provider-name} repositories.

Which issue(s) this PR fixes:
Fixes #216

Special notes for your reviewer:

Release note:

NONE

CLAassistant · 2021-06-02T18:52:09Z

All committers have signed the CLA.

gardener-robot · 2021-06-02T18:52:18Z

@rkjakeer Thank you for your contribution.

gardener-robot-ci-2 · 2021-06-02T18:52:22Z

Thank you @rkjakeer for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

prashanth26 · 2021-06-03T05:10:15Z

Hi @rkjakeer ,

Thanks for this PR. Might need a couple of days to have a look.
/assign
/cla

gardener-robot · 2021-06-03T05:10:20Z

@prashanth26 I reached out successfully to the cla-assistant to recheck this pull request.

prashanth26 · 2021-06-03T05:11:56Z

Also, I think your commits are coming from different user names. Please try to amend the commits to make them originate from a single ID. Also do sign the CLA as requested by the bot.

gardener-robot · 2021-06-10T12:41:48Z

@rkjakeer You need rebase this pull request with latest master branch. Please check.

prashanth26 · 2021-06-16T09:40:59Z

No change required for IT - #623.

gardener-robot · 2021-06-17T13:40:24Z

@rkjakeer You need rebase this pull request with latest master branch. Please check.

pkg/test/integration/common/framework.go

AxiomSamarth · 2021-06-29T16:51:20Z

Hi @rkjakeer,

Thank you for this amazing PR! I absolutely loved the simplicity of usage. Please find two review comments from my side from my first execution of this suite. And maybe, you can combine the related, relevant code changes into a fewer commits

Summary:

Ran 10 of 10 Specs in 459.012 seconds
FAIL! -- 9 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestController (459.02s)
FAIL

pkg/test/integration/common/framework.go

prashanth26

Hi @rkjakeer @toniajuliejackson ,

Apologies for the delay in reviewing. The tests look really good. We really appreciate the changes. I just have a few minor comments. Looks good to me otherwise.

cc: @amshuman-kr @AxiomSamarth

kubernetes/deployment/out-of-tree/deployment.yaml

pkg/test/integration/common/framework.go

pkg/test/integration/common/helpers/cluster.go

pkg/test/integration/common/helpers/handling_files.go

pkg/test/integration/common/helpers/rbac.go

prashanth26 · 2021-07-01T03:37:53Z

Also lastly it would be great to split the PR into two commits before the final merge. One with your actual changes and the other with vendoring changes.
/squash

rkjakeer · 2021-07-02T01:53:38Z

Hi @rkjakeer @toniajuliejackson ,

Apologies for the delay in reviewing. The tests look really good. We really appreciate the changes. I just have a few minor comments. Looks good to me otherwise.

Hi @prashanth26,

No problem. I have made the changes as suggested.
Thanks a lot for the feedback and the code review.

gardener-robot · 2021-07-16T12:38:28Z

@rkjakeer You need rebase this pull request with latest master branch. Please check.

prashanth26

Thanks for the changes.
/lgtm overall, @AxiomSamarth and @himanshu-kun seem to have tested this. We might need minor refactoring in the future to accommodate this into your CI pipelines.

docs/development/cp_support_new.md

go.mod

* Add integrationtest directory * Use rti interface for integration testing * update makefile Co-Authored-By: Tonia Jackson <[email protected]>

AxiomSamarth · 2021-07-20T04:46:44Z

@prashanth26 I tested this suite against AWS and Azure clusters. Test Suite succeeded for both. This could be merged now.

prashanth26 · 2021-07-20T04:48:17Z

@AxiomSamarth - Thank you for this. We can merge once @rkjakeer confirms.

rkjakeer requested a review from a team as a code owner June 2, 2021 18:52

gardener-robot added the needs/review Needs review label Jun 2, 2021

gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 2, 2021

gardener-robot assigned prashanth26 Jun 3, 2021

gardener-robot added lifecycle/stale Nobody worked on this for 6 months (will further age) needs/rebase Needs git rebase labels Jun 10, 2021

gardener-robot removed the needs/rebase Needs git rebase label Jun 14, 2021

gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/rebase Needs git rebase and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 17, 2021

gardener-robot removed the needs/rebase Needs git rebase label Jun 24, 2021

AxiomSamarth suggested changes Jun 29, 2021

View reviewed changes

pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved

pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved

gardener-robot added the needs/changes Needs (more) changes label Jun 29, 2021

AxiomSamarth suggested changes Jun 30, 2021

View reviewed changes

pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved

prashanth26 reviewed Jul 1, 2021

View reviewed changes

gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Jul 1, 2021

prashanth26 removed the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label Jul 1, 2021

rkjakeer force-pushed the master branch 4 times, most recently from 24d6f52 to 41b35e8 Compare July 16, 2021 12:38

gardener-robot added the needs/rebase Needs git rebase label Jul 16, 2021

rkjakeer requested a review from AxiomSamarth July 16, 2021 12:46

gardener-robot removed the needs/rebase Needs git rebase label Jul 16, 2021

rkjakeer requested a review from prashanth26 July 16, 2021 12:58

prashanth26 approved these changes Jul 19, 2021

View reviewed changes

docs/development/cp_support_new.md Outdated Show resolved Hide resolved

gardener-robot added reviewed/lgtm Has approval for merging needs/second-opinion Needs second review by someone else and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 19, 2021

prashanth26 reviewed Jul 19, 2021

View reviewed changes

go.mod Show resolved Hide resolved

gardener-robot removed the reviewed/lgtm Has approval for merging label Jul 19, 2021

rkjakeer force-pushed the master branch from b3c0f31 to 1079be7 Compare July 19, 2021 07:35

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Jul 19, 2021

rkjakeer and others added 2 commits July 19, 2021 15:04

Add integration test framework

da6ca2c

* Add integrationtest directory * Use rti interface for integration testing * update makefile Co-Authored-By: Tonia Jackson <[email protected]>

perform revendor

5a199a4

rkjakeer force-pushed the master branch from 1079be7 to 5a199a4 Compare July 19, 2021 09:36

gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jul 19, 2021

AxiomSamarth approved these changes Jul 20, 2021

View reviewed changes

prashanth26 merged commit c02bcdf into gardener:master Jul 20, 2021

prashanth26 mentioned this pull request Jul 21, 2021

Adopt integration tests to OOT providers #631

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Integration tests #618

Add Integration tests #618

rkjakeer commented Jun 2, 2021 •

edited

Loading

CLAassistant commented Jun 2, 2021 •

edited

Loading

gardener-robot commented Jun 2, 2021

gardener-robot-ci-2 commented Jun 2, 2021

prashanth26 commented Jun 3, 2021

gardener-robot commented Jun 3, 2021

prashanth26 commented Jun 3, 2021

gardener-robot commented Jun 10, 2021

prashanth26 commented Jun 16, 2021

gardener-robot commented Jun 17, 2021

AxiomSamarth commented Jun 29, 2021 •

edited

Loading

prashanth26 left a comment •

edited

Loading

prashanth26 commented Jul 1, 2021

rkjakeer commented Jul 2, 2021

gardener-robot commented Jul 16, 2021

prashanth26 left a comment

AxiomSamarth commented Jul 20, 2021

prashanth26 commented Jul 20, 2021

Add Integration tests #618

Add Integration tests #618

Conversation

rkjakeer commented Jun 2, 2021 • edited Loading

CLAassistant commented Jun 2, 2021 • edited Loading

gardener-robot commented Jun 2, 2021

gardener-robot-ci-2 commented Jun 2, 2021

prashanth26 commented Jun 3, 2021

gardener-robot commented Jun 3, 2021

prashanth26 commented Jun 3, 2021

gardener-robot commented Jun 10, 2021

prashanth26 commented Jun 16, 2021

gardener-robot commented Jun 17, 2021

AxiomSamarth commented Jun 29, 2021 • edited Loading

prashanth26 left a comment • edited Loading

Choose a reason for hiding this comment

prashanth26 commented Jul 1, 2021

rkjakeer commented Jul 2, 2021

gardener-robot commented Jul 16, 2021

prashanth26 left a comment

Choose a reason for hiding this comment

AxiomSamarth commented Jul 20, 2021

prashanth26 commented Jul 20, 2021

rkjakeer commented Jun 2, 2021 •

edited

Loading

CLAassistant commented Jun 2, 2021 •

edited

Loading

AxiomSamarth commented Jun 29, 2021 •

edited

Loading

prashanth26 left a comment •

edited

Loading