Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test framework for MCM #216

Closed
9 tasks
PadmaB opened this issue Feb 6, 2019 · 1 comment · Fixed by #618
Closed
9 tasks

Integration test framework for MCM #216

PadmaB opened this issue Feb 6, 2019 · 1 comment · Fixed by #618
Labels
component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) kind/epic Large multi-story topic kind/test Test lifecycle/stale Nobody worked on this for 6 months (will further age) platform/all priority/3 Priority (lower number equals higher priority) status/new Issue is new and unprocessed
Milestone

Comments

@PadmaB
Copy link
Contributor

PadmaB commented Feb 6, 2019

Story

As machine-controller-manager developer I want to run a set of integration tests that are easy to validate breaking PRs. This framework must be golang based can be easily expanded to add new tests.

Motivation

Currently, we have a bash based integration tests (IT) here. We would like to have completely refined integration tests for MCM using Golang tests.

The idea would be to have a robust test environment, automates machine/machineSet/machineDeployment creation/deletion and such operations making it is easy for developers to run their tests in an integrated environment, publishing the results.

Acceptance Criteria

  • A Golang Framework to accommodate a robust set of integration tests that can be easily adapted.
  • Ensure the end-to-end automation
  • Validate the results
  • Integrate the existing tests into TestMachinery. Refer - gardener extension GCP, etcd backup restore tests

Definition of Done

  • Knowledge is distributed: Have you spread your knowledge in pair programming/code review?
  • Integration tests are provided: Have you written automated integration tests?
  • Minimum API exposure: If you have added/changed public API, was it really necessary/is it minimal?
  • Operations guide: Have you updated the operations guide about ops-relevant changes?
  • User documentation: Have you updated the READMEs/docs/how-tos about user-relevant changes?
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Apr 8, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 7, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 7, 2019
@gardener-robot-ci-2 gardener-robot-ci-2 added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 7, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 removed the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 7, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 6, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 5, 2020
@ghost ghost added component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) and removed component/machine-controller-manager labels Mar 7, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 7, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 7, 2020
@prashanth26 prashanth26 removed the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label Aug 13, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 13, 2020
@hardikdr hardikdr added this to the 2021-Q1 milestone Nov 6, 2020
@hardikdr hardikdr changed the title Integrate mcm tests with TestMachinery Integration with TestMachinery Nov 9, 2020
@prashanth26 prashanth26 changed the title Integration with TestMachinery Integration test framework for MCM Nov 17, 2020
@prashanth26 prashanth26 added the kind/epic Large multi-story topic label Nov 17, 2020
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
@prashanth26
Copy link
Contributor

Adopt the test framework to the out of tree code style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) kind/epic Large multi-story topic kind/test Test lifecycle/stale Nobody worked on this for 6 months (will further age) platform/all priority/3 Priority (lower number equals higher priority) status/new Issue is new and unprocessed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants