Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skaffold tag generation to generate a new tag on code changes (without local commit) #279

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix skaffold tag generation to generate a new tag on code changes (without local commit) #279

merged 1 commit into from
Nov 6, 2024

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind bug

What this PR does / why we need it:
See #278

Which issue(s) this PR fixes:
Fixes #278

Special notes for your reviewer:

Release note:

An issue causing `make extension-up` to do NOT generate a new tag for local source code changes is now fixed.

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Nov 5, 2024
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2024
dimitar-kostadinov
dimitar-kostadinov approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 6, 2024

LGTM label has been added.

Git tree hash: 6d31e299d385727e659ab0161e5cf5b065917cfc

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimitar-kostadinov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2024
@gardener-prow gardener-prow bot merged commit c9e8187 into gardener:main Nov 6, 2024
6 checks passed
@ialidzhikov ialidzhikov deleted the fix/skaffold-tag-generation branch November 7, 2024 12:45
@ialidzhikov ialidzhikov mentioned this pull request Nov 11, 2024
Merged
@ialidzhikov ialidzhikov mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov approved these changes

Assignees

@dimitar-kostadinov dimitar-kostadinov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make extension-up does not generate a new tag on code changes locally
2 participants
@ialidzhikov @dimitar-kostadinov