Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold: Remove custom tagPolicy for the admission #294

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind cleanup

What this PR does / why we need it:
In gardener/gardener-extension-shoot-rsyslog-relp#194 (comment) @plkokanov found that we don't need a custom tagPolicy for the admission.

Which issue(s) this PR fixes:
Follow-up after #279

Special notes for your reviewer:
N/A

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up labels Nov 25, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2024
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
Copy link
Contributor

gardener-prow bot commented Nov 25, 2024

LGTM label has been added.

Git tree hash: 92634ba013a0aa87adbd82c4e2d2a9aba7838cd0

@dimitar-kostadinov
Copy link
Contributor

Root pod creation failed:

  [FAILED] Unexpected error:
      <*errors.joinError | 0xc000150198>: 
      error sending request: Post "https://api.e2e-cache-pr.local.external.local.gardener.cloud/api/v1/namespaces/kube-system/pods/rootpod-865/exec?command=%2Fbin%2Fsh&container=root-container&stderr=true&stdin=true&stdout=true&tty=false": read tcp 172.18.255.1:47188->172.18.255.1:443: read: connection reset by peer
      {
          errs: [
              <*errors.errorString | 0xc00012c100>{
                  s: "error sending request: Post \"https://api.e2e-cache-pr.local.external.local.gardener.cloud/api/v1/namespaces/kube-system/pods/rootpod-865/exec?command=%2Fbin%2Fsh&container=root-container&stderr=true&stdin=true&stdout=true&tty=false\": read tcp 172.18.255.1:47188->172.18.255.1:443: read: connection reset by peer",
              },
          ],
      }
  occurred

/test pull-gardener-extension-registry-cache-e2e-kind

@ialidzhikov
Copy link
Member Author

/approve

Copy link
Contributor

gardener-prow bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@gardener-prow gardener-prow bot merged commit 52295c3 into gardener:main Nov 25, 2024
6 checks passed
@ialidzhikov ialidzhikov deleted the cleanup/custom-tagPolicy branch November 26, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants