Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skaffold tag generation to generate a new tag on code changes (without local commit) #279

Merged
merged 1 commit into from
Nov 6, 2024
+19 −0
Merged

Fix skaffold tag generation to generate a new tag on code changes (without local commit) #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ ci-e2e-kind:
export SKAFFOLD_BUILD_CONCURRENCY = 0
extension-up extension-dev: export SKAFFOLD_DEFAULT_REPO = garden.local.gardener.cloud:5001
extension-up extension-dev: export SKAFFOLD_PUSH = true
extension-up extension-dev: export EXTENSION_VERSION = $(VERSION)
# use static label for skaffold to prevent rolling all gardener components on every `skaffold` invocation
extension-up extension-dev extension-down: export SKAFFOLD_LABEL = skaffold.dev/run-id=extension-local

Expand Down
18 changes: 18 additions & 0 deletions skaffold.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ metadata:
build:
insecureRegistries:
- garden.local.gardener.cloud:5001
tagPolicy:
customTemplate:
template: "{{.version}}-{{.sha}}"
components:
- name: version
envTemplate:
template: "{{.EXTENSION_VERSION}}"
- name: sha
inputDigest: {}
artifacts:
- image: local-skaffold/gardener-extension-registry-cache
ko:
Expand Down Expand Up @@ -58,6 +67,15 @@ metadata:
build:
insecureRegistries:
- garden.local.gardener.cloud:5001
tagPolicy:
customTemplate:
template: "{{.version}}-{{.sha}}"
components:
- name: version
envTemplate:
template: "{{.EXTENSION_VERSION}}"
- name: sha
inputDigest: {}
artifacts:
- image: local-skaffold/gardener-extension-registry-cache-admission
ko:
Expand Down