Fix make deploy-debug
#876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind |
1 similar comment
|
/test pull-etcd-druid-e2e-kind |
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind bug
What this PR does / why we need it:
Fix a bug introduced by #842, which added the
-wflag to the go build flags. This has now been removed. Additionally, enabling leader election during debugging caused timeouts due to druid not being able to renew its lease while the developer walks through the code via breakpoints. This has now been fixed by removing leader election when deploying druid in debug mode, and setting replicas to1.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @unmarshall
Release note: