Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build information in logs #842

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Fix build information in logs #842

merged 3 commits into from
Jul 25, 2024

Conversation

shreyas-s-rao
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao commented Jul 24, 2024 •
edited
Loading

How to categorize this PR?

/area logging
/kind bug

What this PR does / why we need it:
Fix build information in logs, due to change in package structure from pkg to internal, as well as missing ldflags in skaffold KO build manifest.

I have also added 3 new Makefile targets: docker-clean, clean-build-cache, clean-mod-cache. The first two are helpful in cleaning up the cache created by KO builds for druid images, to make it easy to test changes in the PR (since KO reuses caches unless something in the code changes, as specified in the skaffold manifest).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @unmarshall

Release note:

Add Make target `make docker-clean` for cleaning up all docker builds related to etcd-druid.

Add Make targets `make clean-build-cache` and `make clean-mod-cache` for cleaning up Go build and mod caches respectively.

@shreyas-s-rao shreyas-s-rao added this to the v0.23.0 milestone Jul 24, 2024
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner July 24, 2024 16:57
@gardener-robot gardener-robot added needs/review Needs review area/logging Logging related kind/bug Bug labels Jul 24, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 24, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jul 24, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 24, 2024
@shreyas-s-rao
Copy link
Contributor Author

/retest

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 25, 2024
seshachalam-yv
seshachalam-yv requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @shreyas-s-rao, for the fix. Overall, it looks good to me. Please address my one review comment.

skaffold.yaml Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jul 25, 2024
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 25, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 25, 2024
@shreyas-s-rao
Copy link
Contributor Author

/retest

seshachalam-yv
seshachalam-yv approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Jul 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 25, 2024
@shreyas-s-rao shreyas-s-rao merged commit 8446c6d into gardener:master Jul 25, 2024
11 checks passed
@shreyas-s-rao shreyas-s-rao deleted the fix/logs/build-info branch July 25, 2024 11:29
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 25, 2024
@ishan16696 ishan16696 mentioned this pull request Jul 30, 2024
Merged
@shreyas-s-rao shreyas-s-rao mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

Assignees

@shreyas-s-rao shreyas-s-rao

@seshachalam-yv seshachalam-yv

Labels
area/logging Logging related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@shreyas-s-rao @seshachalam-yv @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot