Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make deploy-debug #876

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix make deploy-debug #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ deploy-dev: $(SKAFFOLD) $(HELM)

.PHONY: deploy-debug
deploy-debug: $(SKAFFOLD) $(HELM)
@VERSION=$(VERSION) GIT_SHA=$(GIT_SHA) $(SKAFFOLD) debug --cleanup=false -m etcd-druid
@VERSION=$(VERSION) GIT_SHA=$(GIT_SHA) $(SKAFFOLD) debug --cleanup=false -m etcd-druid -p debug

.PHONY: undeploy
undeploy: $(SKAFFOLD) $(HELM)
Expand Down
12 changes: 11 additions & 1 deletion skaffold.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ build:
flags:
- -v
ldflags:
- -w
- -X github.com/gardener/etcd-druid/internal/version.Version={{.VERSION}}
- -X github.com/gardener/etcd-druid/internal/version.GitSHA={{.GIT_SHA}}
deploy:
Expand All @@ -31,6 +30,17 @@ deploy:
setValues: # empty `setValues` value is not allowed
foo: bar
profiles:
# Profile to disable druid leader election, to allow debugging without abrupt exits due to failure to renew leader election lease within time.
- name: debug
patches:
- op: add
path: /deploy/helm/releases/0/setValues/replicas
value: 1
- op: add
path: /deploy/helm/releases/0/setValues/controllerManager
value:
leaderElection:
enabled: false
- name: e2e-test
activation:
- env: "DRUID_E2E_TEST=true"
Expand Down