-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain project dependencies and images #141
Merged
amshuman-kr
merged 4 commits into
gardener:master
from
timuthy:maintenance.dependencies
Mar 10, 2021
Merged
Maintain project dependencies and images #141
amshuman-kr
merged 4 commits into
gardener:master
from
timuthy:maintenance.dependencies
Mar 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Feb 25, 2021
timuthy
changed the title
Maintenance.dependencies
Maintain project dependencies and images
Feb 25, 2021
gardener-robot
added
needs/review
Needs review
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
labels
Feb 25, 2021
gardener-robot-ci-2
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Feb 25, 2021
timuthy
force-pushed
the
maintenance.dependencies
branch
from
February 26, 2021 07:32
879f102
to
d74d510
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Feb 26, 2021
timuthy
force-pushed
the
maintenance.dependencies
branch
from
March 1, 2021 14:31
d74d510
to
cdf11ca
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Mar 1, 2021
Merged
ping @gardener/etcd-druid-maintainers |
/lgtm |
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
labels
Mar 10, 2021
timuthy
force-pushed
the
maintenance.dependencies
branch
from
March 10, 2021 11:52
cdf11ca
to
5dacf1b
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Mar 10, 2021
gardener-robot
added
needs/second-opinion
Needs second review by someone else
needs/review
Needs review
and removed
reviewed/lgtm
Has approval for merging
labels
Mar 10, 2021
Thanks @amshuman-kr. I've resolved the merge conflicts and will continue with #146 once this PR is merged. |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Mar 10, 2021
Thanks @timuthy! I will try to merge this using rebase instead of merge. Hope that avoids one more rebase for you. |
/lgtm |
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
labels
Mar 10, 2021
amshuman-kr
approved these changes
Mar 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates dependency of the druid component.
Along the way, it improves several things:
make check
in favor ofgo vet
only (Make targetvet
has been dropped)make revendor
now updates.github
templates fromgardener/gardener
controller-gen
from thevendor
directory is now considered to generate assets in order to generate a stable outputlease.coordination.k8s.io
based leader election in the future (/cc @timebertt)/cc @shreyas-s-rao @amshuman-kr
I split the PR into different commits to make reviewing easier. HTH.
Release note: