Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain project dependencies and images #141

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Feb 25, 2021

What this PR does / why we need it:
This PR updates dependency of the druid component.

Along the way, it improves several things:

  • Gardener's check script is now executed as part of make check in favor of go vet only (Make target vet has been dropped)
  • make revendor now updates .github templates from gardener/gardener
  • Several golang-ci findings have been resolved
  • The controller-gen from the vendor directory is now considered to generate assets in order to generate a stable output
  • Curl has been removed from the Druid image for security reasons
  • New leader election options have been added to eventually migrate to lease.coordination.k8s.io based leader election in the future (/cc @timebertt)

⚠️ PR #139 must be merged first!

/cc @shreyas-s-rao @amshuman-kr

I split the PR into different commits to make reviewing easier. HTH.

Release note:

Several Go and image dependencies have been updated.
- [Gardener's check script](https://github.com/gardener/gardener/blob/master/hack/check.sh) is now executed as part of `make check` in favor of `go vet` only (Make target `vet` has been dropped)
- `make revendor` now updates `.github` templates from `gardener/gardener`
- Several golang-ci findings have been resolved
- The `controller-gen` from the `vendor` directory is now considered to generate assets in order to get a stable output.
etcd-druid images won't be delivered with `curl` anymore.
etcd-druid now needs CRUD permissions for `leaese.coordination.k8s.io` object in order to perform leader election.

@timuthy timuthy requested a review from a team as a code owner February 25, 2021 17:46
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2021
@timuthy timuthy changed the title Maintenance.dependencies Maintain project dependencies and images Feb 25, 2021
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Feb 25, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2021
@timuthy timuthy force-pushed the maintenance.dependencies branch from 879f102 to d74d510 Compare February 26, 2021 07:32
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 26, 2021
@timuthy timuthy force-pushed the maintenance.dependencies branch from d74d510 to cdf11ca Compare March 1, 2021 14:31
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2021
@timuthy timuthy mentioned this pull request Mar 1, 2021
@timuthy
Copy link
Member Author

timuthy commented Mar 5, 2021

ping @gardener/etcd-druid-maintainers

@amshuman-kr
Copy link
Collaborator

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 10, 2021
@amshuman-kr
Copy link
Collaborator

Sorry for the delay, @timuthy. I have merged #139. But now this PR has a conflict because I think it has a commit in common with #139. Can you please rebase?

I probably will request you to rebase #146 after this PR is merged because there are common commits there too.

@timuthy timuthy force-pushed the maintenance.dependencies branch from cdf11ca to 5dacf1b Compare March 10, 2021 11:52
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 10, 2021
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Mar 10, 2021
@timuthy
Copy link
Member Author

timuthy commented Mar 10, 2021

Thanks @amshuman-kr. I've resolved the merge conflicts and will continue with #146 once this PR is merged.

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 10, 2021
@amshuman-kr
Copy link
Collaborator

Thanks @amshuman-kr. I've resolved the merge conflicts and will continue with #146 once this PR is merged.

Thanks @timuthy! I will try to merge this using rebase instead of merge. Hope that avoids one more rebase for you.

@amshuman-kr
Copy link
Collaborator

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants