Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read PVC warning events #146

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Read PVC warning events #146

merged 2 commits into from
Mar 12, 2021

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Mar 1, 2021

What this PR does / why we need it:
This PR makes Druid read events for PVCs if they are still unbound after a StatefulSet does not get ready. Respective warnings will appear in the .status.lastError description which makes it easier for operators to spot the root cause.

Special notes for your reviewer:
⚠️ This PR is based on #141. Only commit 924a361 is relevant for this PR.

Release note:

If an etcd `StatefulSet` remains pending, warning events of unbound `PVC`s are now added to the `.status.lastError` of the `etcd` resource. This makes it easier for operators to spot potential issues.

@timuthy timuthy requested a review from a team as a code owner March 1, 2021 15:07
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2021
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 1, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2021
@timuthy
Copy link
Member Author

timuthy commented Mar 5, 2021 •
edited
Loading

/ping @gardener/etcd-druid-maintainers

@gardener-robot
Copy link

@gardener/etcd-druid-maintainers

Message

/ping @gardener/etcd-druid-maintainers

@amshuman-kr amshuman-kr mentioned this pull request Mar 10, 2021
Merged
@amshuman-kr
Copy link
Collaborator

@timuthy Even if I used rebase while merging #141, there are still conflicts. I am sorry, I have to request you to rebase this PR also.

@timuthy
Copy link
Member Author

timuthy commented Mar 10, 2021

Thanks for taking care and no worries @amshuman-kr. I noticed that due to the update to a newer Go version, I'll also have to adjust the CI/CD check step which is currently failing.

@timuthy
Copy link
Member Author

timuthy commented Mar 10, 2021

I filed #150 to fix the pipeline. After it's been merged, I'll resolve the conflicts in this PR.

@amshuman-kr
Copy link
Collaborator

Thanks @timuthy . I have merged #150. Please proceed with the rebase/resolving conflicts.

@timuthy timuthy force-pushed the feature.pvc-events branch from 924a361 to af6efb4 Compare March 11, 2021 08:55
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) and removed size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Mar 11, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2021
@timuthy
Copy link
Member Author

timuthy commented Mar 11, 2021

Thanks @amshuman-kr, I've resolved the conflicts in this PR.

amshuman-kr
amshuman-kr approved these changes Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@amshuman-kr amshuman-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing @timuthy! LGTM

shreyas-s-rao
shreyas-s-rao requested changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timuthy thanks for your PR. I was somehow not able to reproduce the desired working of the functionality of the PR. To reproduce, I deliberately failed the PVC from binding by specifying a random storage class, and the PVC is in pending state, but druid doesn't print the PVC unbound warning as expected. Instead, I get error 'non-exact field matches are not supported by the cache' occurred while fetching more details. Do you have any idea about this?

controllers/etcd_controller.go Show resolved Hide resolved
controllers/etcd_controller.go Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 12, 2021
@timuthy
Copy link
Member Author

timuthy commented Mar 12, 2021

Thanks @shreyas-s-rao for your review. I fixed the bug you experienced in 8f14dc9. Unfortunately, the cache exclusion for events only happened for the Env tests. Can you try it again?

@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 12, 2021
@timuthy timuthy force-pushed the feature.pvc-events branch from 8f14dc9 to a4369b9 Compare March 12, 2021 12:04
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 12, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 12, 2021
shreyas-s-rao
shreyas-s-rao approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timuthy Thanks for making the changes. Tested the PR now, and it works as expected. LGTM

@shreyas-s-rao shreyas-s-rao merged commit 3b9cd9a into gardener:master Mar 12, 2021
@timuthy timuthy deleted the feature.pvc-events branch March 12, 2021 13:40
@dependabot dependabot bot mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@amshuman-kr amshuman-kr amshuman-kr approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@timuthy @gardener-robot @amshuman-kr @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3