Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pipeline images #139

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Update pipeline images #139

merged 1 commit into from
Mar 10, 2021

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Feb 25, 2021

What this PR does / why we need it:
This PR updates the used pipeline images to Go 1.15.8. This is required for further dependency updates.

Release note:

NONE

@timuthy timuthy requested a review from a team as a code owner February 25, 2021 11:25
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 25, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2021
@timuthy timuthy mentioned this pull request Feb 25, 2021
Merged
@vpnachev
Copy link
Member

vpnachev commented Mar 3, 2021

How about enabling kaniko and keep using the dockerhub images?
Ref: gardener/gardener-extension-provider-aws#281

@timuthy
Copy link
Member Author

timuthy commented Mar 4, 2021

Thanks @vpnachev. If that's now our way to go, I'll adjust the PR.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 4, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 4, 2021
vpnachev
vpnachev approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 4, 2021
@timuthy
Copy link
Member Author

timuthy commented Mar 5, 2021

@shreyas-s-rao any chance to get this in?

@amshuman-kr
Copy link
Collaborator

/lgtm

@amshuman-kr
Copy link
Collaborator

Sorry about the delay @timuthy! Merging now.

@amshuman-kr amshuman-kr merged commit b83ae2b into gardener:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timuthy @vpnachev @amshuman-kr @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot