-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with upstream v1.21.3 #129
Sync with upstream v1.21.3 #129
Conversation
While this was previously effectively limited to 50, `DescribeAutoScalingGroups` now supports fetching 100 ASG per calls on all regions, matching what's documented: https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_DescribeAutoScalingGroups.html ``` AutoScalingGroupNames.member.N The names of the Auto Scaling groups. By default, you can only specify up to 50 names. You can optionally increase this limit using the MaxRecords parameter. MaxRecords The maximum number of items to return with this call. The default value is 50 and the maximum value is 100. ``` Doubling this halves API calls on large clusters, which should help to prevent throttling.
Refactor to allow for optimisation
The pricing json for us-east-1 is currently 129MB. Currently fetching this into memory and parsing results in a large memory footprint on startup, and can lead to the autoscaler being OOMKilled. Change the ReadAll/Unmarshal logic to a stream decoder to significantly reduce the memory use.
…pick-of-#3999-kubernetes#4199-upstream-cluster-autoscaler-release-1.21 Automated cherry pick of kubernetes#3999 kubernetes#4127 kubernetes#4199 upstream cluster autoscaler release 1.21
…packet-fix Cloud provider[Packet] fixes
Backport Merge pull request kubernetes#4274 to upstream/cluster-autoscaler-release-1.21
Both upscale's `getUpcomingNodeInfos` and the binpacking estimator now uses the same shared DeepCopyTemplateNode function and inherits its naming pattern, which is great as that fixes a long standing bug. Due to that, `getUpcomingNodeInfos` will enrich the cluster snapshots with generated nodeinfos and nodes having predictable names (using template name + an incremental ordinal starting at 0) for upcoming nodes. Later, when it looks for fitting nodes for unschedulable pods (when upcoming nodes don't satisfy those (FitsAnyNodeMatching failing due to nodes capacity, or pods antiaffinity, ...), the binpacking estimator will also build virtual nodes and place them in a snapshot fork to evaluate scheduler predicates. Those temporary virtual nodes are built using the same pattern (template name and an index ordinal also starting at 0) as the one previously used by `getUpcomingNodeInfos`, which means it will generate the same nodeinfos/nodes names for nodegroups having upcoming nodes. But adding nodes by the same name in an existing cluster snapshot isn't allowed, and the evaluation attempt will fail. Practically this blocks re-upscales for nodegroups having upcoming nodes, which can cause a significant delay.
Cluster Autoscaler: Backport kubernetes#4089 to 1.21
Signed-off-by: Sylvain Rabot <[email protected]>
Cherry pick 535a212 onto 1.21 - Fix logging level
Cherry-pick kubernetes#4130 onto 1.21: dont proactively decrement azure cache for unregistered nodes
Cluster Autoscaler 1.21.1
…ist-Update-03-10-21-1.21 CA - AWS - Instance List Update 03-10-21 - 1.21 release branch
…ist-Update-29-10-21-1.21 CA - AWS - Instance List Update 29-10-21 - 1.21 release branch
…ist-Update-29-11-21-1.21 Cluster-Autoscaler update AWS EC2 instance types with g5, m6 and r6 - 1.21 release branch
…nce-types add more azure instance types
…elease-1.21 Cherry-pick kubernetes#4497 onto 1.21 - add more azure instance types
…ist-Update-13-12-21-1.21 CA - AWS Instance List Update - 13/12/21 - 1.21
Cluster Autoscaler 1.21.2
…migration enabled) Signed-off-by: ialidzhikov <[email protected]>
…ler-release-1.21-nodegroup-minmax [cluster-autoscaler] backport kubernetes#4022 Publish node group min/max metrics into 1.21
…dd flag to control DaemonSet eviction on non-empty nodes & Allow DaemonSet pods to opt in/out from eviction.
Instead of logging a fatal error, log a standard error and fall back to loading instance types from the static list.
…ease-1.21-aws-fallback CA - AWS Cloud Provider - 1.21 - fix instance type fallback
…r-release-1.21-aws-instance-update-02-06-2022 CA - AWS Cloud Provider - 1.21 Static Instance List Update 02-06-2022
…release-1.21-daemonset-eviction-for-empty-nodes-and-occupied-nodes Backport kubernetes#4162 and kubernetes#4172 [cluster-autoscaler] "Add a flag to control DaemonSet eviction on non-empty nodes and Allow DaemonSet pods to opt in/out from eviction" into 1.21
…r-release-1.21.3 Cluster Autoscaler - 1.21.3 release
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: