dont proactively decrement azure cache for unregistered nodes #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/azure
k8s-ci-robot
added
the
approved
marwanad
force-pushed
the
dont-decrement-azure-cache
branch
from
fb25ce2 to
756a3e1
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, marwanad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@marwanad do we need cherry-pick this to older releases? |
This was referenced Sep 27, 2021
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 28, 2021
Cherry-pick #4130: dont proactively decrement azure cache for unregistered nodes
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 28, 2021
Cherry-pick #4130: dont proactively decrement azure cache for unregistered nodes
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 1, 2021
Cherry-pick #4130 onto 1.21: dont proactively decrement azure cache for unregistered nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because for unregistered failed nodes, the capacity field on the VMSS already excludes and so this avoids a scenario where the cached capacity drifts significantly from the VMSS one (if cache TTL is long) and inadvertently lead to a scale down on the next scale up operation.
/area provider/azure