Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #4162 and #4172 [cluster-autoscaler] "Add a flag to control DaemonSet eviction on non-empty nodes and Allow DaemonSet pods to opt in/out from eviction" into 1.21 #4916

Conversation

Shubham82
Copy link
Contributor

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is actually a backport which backport #4162 and #4172 in cluster-autoscaler-1.21

Which issue(s) this PR fixes:

Fixes #4830

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Backport "Add a flag to control DaemonSet eviction on non-empty nodes and Allow DaemonSet pods to opt in/out from eviction". 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

…dd flag to control DaemonSet eviction on non-empty nodes & Allow DaemonSet pods to opt in/out

from eviction.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2022
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and towca May 25, 2022 09:55
@Shubham82
Copy link
Contributor Author

Hi @feiskyer @towca
Could you please take a look!

@Shubham82
Copy link
Contributor Author

@MaciekPytel @mwielgus
PTAL!

@Shubham82
Copy link
Contributor Author

Hi @gjtempleton
PTAL!

@gjtempleton
Copy link
Member

gjtempleton commented Jun 3, 2022

Hey, thanks for raising this.

I'm a bit wary on merging this as it appears to be a new feature rather than a bug-fix, and our preference is to backport only bug-fixes. Thoughts @MaciekPytel ?

Edit: FWIW, improving our docs on the release/contribution process, including our cherry-pick policy is on my list of things to do in the future.

@Shubham82
Copy link
Contributor Author

Hi @gjtempleton, thanks for looking at this
something like this(feature) also backport previously. For ref #4700

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, Shubham82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit a263aa1 into kubernetes:cluster-autoscaler-release-1.21 Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants