-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #4162 and #4172 [cluster-autoscaler] "Add a flag to control DaemonSet eviction on non-empty nodes and Allow DaemonSet pods to opt in/out from eviction" into 1.21 #4916
Backport #4162 and #4172 [cluster-autoscaler] "Add a flag to control DaemonSet eviction on non-empty nodes and Allow DaemonSet pods to opt in/out from eviction" into 1.21 #4916
Conversation
…dd flag to control DaemonSet eviction on non-empty nodes & Allow DaemonSet pods to opt in/out from eviction.
@MaciekPytel @mwielgus |
Hi @gjtempleton |
Hey, thanks for raising this. I'm a bit wary on merging this as it appears to be a new feature rather than a bug-fix, and our preference is to backport only bug-fixes. Thoughts @MaciekPytel ? Edit: FWIW, improving our docs on the release/contribution process, including our cherry-pick policy is on my list of things to do in the future. |
Hi @gjtempleton, thanks for looking at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwielgus, Shubham82 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is actually a backport which backport #4162 and #4172 in cluster-autoscaler-1.21
Which issue(s) this PR fixes:
Fixes #4830
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: