[improve][admin]internalGetMessageById shouldn't be allowed on partitioned topic #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaozhangmin
changed the title
gaozhangmin
force-pushed
the
getMessageById
branch
from
934ec9a to
86596c5
Compare
…meterized string formatting (apache#18968) Co-authored-by: Ali Ahmed <[email protected]>
Co-authored-by: fengwenzhi <[email protected]>
…partitioned topics (apache#19021)
…active release branches (apache#19024) (apache#19034)
Co-authored-by: lushiji <[email protected]>
Signed-off-by: tison <[email protected]>
…for paritioned topic stats-internal (apache#19044) Signed-off-by: ericsyh <[email protected]>
…#19065) Signed-off-by: tison <[email protected]>
…#19058) ### Motivation Currently, Hadoop versions for pulsar-io-hdfs2 and hdfs3 is hard-coded in their pom.xml, but it's not so convenient for users who want to build Pulsar against specific version of Hadoop. ### Modifications This PR defines those versions as Maven properties just like other Pulsar IO modules so that users can easily override them with Maven's `-D` option at compile time.
…nStatus (apache#19054) ### Motivation Fix missing `return null` if throw any exception when `internalGetReplicatedSubscriptionStatus` ### Modifications Add `return null` when handing exception in `internalGetReplicatedSubscriptionStatus`.
…ing critical metadata operation paths (apache#18518)
Signed-off-by: tison <[email protected]> Co-authored-by: congbobo184 <[email protected]>
) Fixes [apache#18825](apache#18825) ### Motivation Admin API can upload `BYTES` schema and store a `NONE` schema in the schema registry, which is inconsistent with the client side. After discussion, we decided to forbid users from uploading `BYTES` schema. Mail list: https://lists.apache.org/thread/672zmptfblwjmrf9z8336mk12r7csngf ### Modifications Add a check to reject `BYTES` schema upload.
Signed-off-by: tison <[email protected]>
…ssignment strategy to the load balancer extensions (apache#18964) Master Issue: apache#16691 ### Motivation We will start raising PRs to implement PIP-192, apache#16691 ### Modifications This PR Added `LeastResourceUsageWithWeight` to the load balancer extensions and its unit test. For the pip-192 project, this LeastResourceUsageWithWeight - is a copy of the existing broker-bundle assignment strategy, `org.apache.pulsar.broker.loadbalance.impl.LeastResourceUsageWithWeight`. - uses the load data from the load balancer extensions.
Signed-off-by: tison <[email protected]>
…than the greatest ledgerId (apache#19017)
Signed-off-by: Max Xu <[email protected]> Motivation pulsar-admin sources list has the wrong parameters description. Modifications Should be pulsar-admin sources list --namespace <The source's namespace> --tenant <The source's tenant>
…le Affinity broker url (apache#18663) Co-authored-by: Vineeth <[email protected]>
…skip them when reading messages from bookies - part7 (apache#19035)
gaozhangmin
force-pushed
the
getMessageById
branch
from
eddad52 to
73a5586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Master Issue: #xyz
PIP: #xyz
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: