Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Move the SimpleProducerConsumerTest out of the flaky test group #19060

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Dec 26, 2022

Motivation

The SimpleProducerConsumerTest is the very common test for the Pulsar APIs. But it is under the flaky test group, the PR can be merged without this test getting passed. Since we have fixed many flaky tests in the last 3 months. I have run the test on my laptop multiple times. Looks like it works stable for now.

So move the test out of the flaky test group. And it also give us a chance to fix the flaky test in SimpleProducerConsumerTest if there are some tests still flaky.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 26, 2022
@codelipenghui codelipenghui self-assigned this Dec 26, 2022
@codelipenghui
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Merging #19060 (c766989) into master (cbf5487) will increase coverage by 2.32%.
The diff coverage is 61.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19060      +/-   ##
============================================
+ Coverage     45.10%   47.42%   +2.32%     
+ Complexity    10854    10700     -154     
============================================
  Files           769      710      -59     
  Lines         74178    69423    -4755     
  Branches       7982     7449     -533     
============================================
- Hits          33455    32927     -528     
+ Misses        36974    32807    -4167     
+ Partials       3749     3689      -60     
Flag Coverage Δ
unittests 47.42% <61.90%> (+2.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache/pulsar/broker/admin/v2/PersistentTopics.java 72.04% <ø> (-2.36%) ⬇️
...che/pulsar/broker/service/BacklogQuotaManager.java 12.39% <0.00%> (ø)
...ker/stats/prometheus/NamespaceStatsAggregator.java 0.00% <0.00%> (ø)
.../org/apache/pulsar/client/impl/ConnectionPool.java 38.46% <0.00%> (ø)
...sar/broker/service/persistent/PersistentTopic.java 61.55% <50.00%> (+0.22%) ⬆️
...he/pulsar/broker/admin/v2/PersistentTopicsExt.java 76.92% <76.92%> (ø)
.../org/apache/pulsar/broker/admin/AdminResource.java 65.43% <100.00%> (-0.93%) ⬇️
.../pulsar/client/impl/PulsarServiceNameResolver.java 89.74% <100.00%> (ø)
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 21.62% <0.00%> (-45.95%) ⬇️
.../pulsar/broker/service/SharedConsumerAssignor.java 61.11% <0.00%> (-16.67%) ⬇️
... and 115 more

@Technoboy- Technoboy- added this to the 2.12.0 milestone Dec 26, 2022
@codelipenghui codelipenghui merged commit 9f9f73c into apache:master Dec 26, 2022
@codelipenghui codelipenghui deleted the penghui/move-test branch December 26, 2022 13:42
tisonkun pushed a commit to tisonkun/pulsar that referenced this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants