Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove docs from the main repo #19100

Merged
merged 1 commit into from
Dec 29, 2022
Merged

[refactor] Remove docs from the main repo #19100

merged 1 commit into from
Dec 29, 2022

Conversation

tisonkun
Copy link
Member

This closes #19092.

Mailing list resolution: https://lists.apache.org/thread/89wl112cflvtoyfg3l7kglr1dozsljm9

All pending PRs updating site2 content should be resubmitted. I'm trying to merge them if acceptable now.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@tisonkun tisonkun self-assigned this Dec 29, 2022
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 29, 2022
@Anonymitaet
Copy link
Member

Hi @tisonkun thanks for your work!

I have several questions, can you take a look? Thank you!

After this PR gets merged,

  1. Will the documentation bot (used to label PR with doc-related labels) be implemented in pulsar-site and removed in pulsar?

  2. Will the sync workflow (sync docs from pulsar to pulsar-site) be removed?

  3. Will the doc-related issues still be recorded in pulsar?

@tisonkun
Copy link
Member Author

tisonkun commented Dec 29, 2022

Will the documentation bot (used to label PR with doc-related labels) be implemented in pulsar-site and removed in pulsar?

No. At least not yet. There are still PRs in apache/pulsar touch docs other than site2. Said other markdown files or inline comments.

And what's more important, doc-required and doc-completed are still valuable to associate with PRs in the main repo.

But yes, we can install the documentation bot in apache/pulsar-site if necessary. Although we may at first try to regard all changes in the site repo is about "doc".

Will the sync workflow (sync docs from pulsar to pulsar-site) be removed?

See apache/pulsar-site#348. We may still generate CLI references and swagger docs from main repo periodically. But since the docs content gets removed, we don't sync them (nothing to sync, actually).

Will the doc-related issues still be recorded in pulsar?

Yes. IIRC they're labeled as doc-required. Users find an issue and submit on the main repo. We triage and handle them.

@Anonymitaet
Copy link
Member

Anonymitaet commented Dec 29, 2022

Although we may at first try to regard all changes in the site repo is about "doc".

They also include website-related changes, e.g., changing the background color. So it's better to have the doc bot working in pulsar-site and label doc-related PRs with corresponding doc labels.

@tisonkun
Copy link
Member Author

@Anonymitaet Make sense. File an issue #19103.

I'll do it as a follow-up.

@tisonkun
Copy link
Member Author

Merging...

@momo-jun @Anonymitaet PRs touch site2 files need to be resubmitted against the site repo. Ping me if any issue.

@tisonkun tisonkun merged commit c13f389 into master Dec 29, 2022
@tisonkun tisonkun deleted the tisonkun-patch-1 branch December 29, 2022 13:00
tisonkun pushed a commit to tisonkun/pulsar that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove docs from the main repo
4 participants