Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document connecting through a proxy #408

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Document connecting through a proxy #408

merged 2 commits into from
Feb 15, 2023

Conversation

michaeljmarshall
Copy link
Member

@michaeljmarshall michaeljmarshall commented Feb 14, 2023 •
edited
Loading

Documentation

Adding docs for apache/pulsar#19455

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link
Contributor

@michaeljmarshall Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@michaeljmarshall michaeljmarshall mentioned this pull request Feb 14, 2023
Merged
2 tasks
@michaeljmarshall
Copy link
Member Author

Why are we checking the doc label here? Are almost all of these changes docs changes?

@tisonkun
Copy link
Member

@michaeljmarshall here is the background: apache/pulsar#19100 (comment)

... while I'm open to install or not. You may argue that since the source of docs moved out, most contributions to the main repo is not docs related.

@michaeljmarshall
Copy link
Member Author

Thanks for that context @tisonkun!

@michaeljmarshall michaeljmarshall added doc Improvements or additions to documentation and removed doc-label-missing labels Feb 14, 2023
@github-actions github-actions bot added doc-label-missing and removed doc Improvements or additions to documentation labels Feb 14, 2023
Anonymitaet
Anonymitaet approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Approved from a technical writing perspective.

@github-actions github-actions bot added doc Improvements or additions to documentation and removed doc-label-missing labels Feb 15, 2023
@michaeljmarshall michaeljmarshall merged commit 348701a into apache:main Feb 15, 2023
@michaeljmarshall michaeljmarshall deleted the connect branch February 15, 2023 04:04
@michaeljmarshall michaeljmarshall mentioned this pull request Apr 20, 2023
Merged
1 task
@Anonymitaet Anonymitaet added this to the 3.0.0 milestone Apr 28, 2023
momo-jun added a commit to momo-jun/pulsar-site that referenced this pull request May 30, 2023
@momo-jun
sync doc updates of apache#408 (for #19270)
5a35b53
@momo-jun momo-jun mentioned this pull request May 30, 2023
Merged
4 tasks
momo-jun added a commit that referenced this pull request Jun 2, 2023
@momo-jun
Sync doc updates for proxyRole to versioned docs (#593)
d01a11c 
* sync doc updates of #408 (for #19270)

* remove the conditional requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anonymitaet Anonymitaet Anonymitaet approved these changes

Assignees
No one assigned
Labels
doc Improvements or additions to documentation
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeljmarshall @tisonkun @Anonymitaet