Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical trigger #33

Closed
2 of 7 tasks
gz65555 opened this issue Feb 4, 2021 · 5 comments · Fixed by #505
Closed
2 of 7 tasks

Physical trigger #33

gz65555 opened this issue Feb 4, 2021 · 5 comments · Fixed by #505
Assignees
Labels
enhancement New feature or request high priority High priority issue physics Engine's physical system
Milestone

Comments

@gz65555
Copy link
Collaborator

gz65555 commented Feb 4, 2021

Realize basic physical trigger function and colliders:

  • Box
  • Sphere
  • Capsule
  • Plane
  • TriangleMesh
  • ConvexMesh
  • HeightField

PR reviewers: @GuoLei1990 , @cptbtptpbcptdtptp , @singlecoder

@gz65555 gz65555 added the enhancement New feature or request label Feb 4, 2021
@gz65555 gz65555 added this to the 0.3 milestone Feb 4, 2021
@husong-sudo husong-sudo modified the milestones: 0.3, 0.4 Mar 19, 2021
@GuoLei1990 GuoLei1990 changed the title Physical System Basic physical function Apr 13, 2021
@GuoLei1990 GuoLei1990 modified the milestones: 0.4, 0.6 Apr 13, 2021
@GuoLei1990 GuoLei1990 changed the title Basic physical function [Physic system] Trigger Apr 13, 2021
@GuoLei1990 GuoLei1990 modified the milestones: 0.6, 0.5 Apr 13, 2021
@GuoLei1990 GuoLei1990 added Long term physics Engine's physical system and removed enhancement New feature or request Long term labels Apr 13, 2021
@GuoLei1990 GuoLei1990 changed the title [Physic system] Trigger Physical trigger Apr 13, 2021
@GuoLei1990 GuoLei1990 added the enhancement New feature or request label Apr 13, 2021
@GuoLei1990 GuoLei1990 modified the milestones: 0.5, 0.6 Jun 18, 2021
@GuoLei1990 GuoLei1990 assigned yangfengzzz and unassigned czizzy Jul 1, 2021
@yangfengzzz
Copy link
Member

yangfengzzz commented Jul 12, 2021

Collider is for collision detection and all related to PxShape in PhysX. PxShape is related with PxGeometry which include PxBoxGeometry, PxSphereGeometry, PxCapsuleGeometry, PxPlaneGeometry, PxTriangleMeshGeometry, PxConvexMeshGeometry, PxHeightFieldGeometry(Terrain). There will be a corresponding collider for each geometry.

After creation, the object of PxShape is attach on the object of PxActor(Rigidbody). #187

@yangfengzzz
Copy link
Member

PxShape must contains PxMaterial which define the surface property including DynamicFriction, StaticFriction, Restitution, FrictionCombineMode, RestitutionCombineMode.

@yangfengzzz
Copy link
Member

WASM is not faster than JavaScript everywhere(inline function) and we must consider minimize the size of WASM binary and reduce the number of binding APIs. It is worth to consider lazy operations which prepare all necessary data in JS and then create the object of WASM.

@yangfengzzz yangfengzzz added the high priority High priority issue label Jul 14, 2021
@yangfengzzz
Copy link
Member

In PhysX, the major types have following relationship: PxGeometry——PxShape——PxActor——PxScene, there are different geometries but all these must be attached in an actor. If we don't want to create Rigidbody, we have to use PxRigidStatic, which is static and only work as a trigger.

@yangfengzzz
Copy link
Member

Need to distinguish trigger and collider, the former does not require physical feedback, the latter requires physical feedback, so it can be implemented in different ways to reduce the size of WASM binary.

@yangfengzzz yangfengzzz linked a pull request Sep 6, 2021 that will close this issue
3 tasks
@yangfengzzz yangfengzzz linked a pull request Sep 11, 2021 that will close this issue
3 tasks
GuoLei1990 pushed a commit to GuoLei1990/galacean-engine that referenced this issue Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority High priority issue physics Engine's physical system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants