-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhysX based raycast and collider #489
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/0.6 #489 +/- ##
==========================================
Coverage ? 47.13%
==========================================
Files ? 366
Lines ? 19216
Branches ? 2548
==========================================
Hits ? 9058
Misses ? 10158
Partials ? 0 Continue to review full report at Codecov.
|
import { Collider } from "./Collider"; | ||
import { IBoxCollider } from "@oasis-engine/design"; | ||
|
||
export class BoxCollider extends Collider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add class commentes.
* set size of collider | ||
* @param value size of BoxCollider | ||
*/ | ||
set size(value: Vector3) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write comments in get
and don't need write @param
comments.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
#386 #378 #33
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: