-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove base plot #38
Remove base plot #38
Conversation
added inital slice plot, mesh plot
adds get_extent function
added requested_units to functions
added pep formatter
refactored code into core and utils, improved examples and CI
moving to new openmc_tally_unit_convertor package
added option for title
updated to work with openmc_tally_unit_converter 0.5.2
Patch release 0.2.3
@RemDelaporteMathurin this failing CI is due to a conda bug that has been reported elsewhere. We could fix the CI by using mamba install. I can do this on a new PR |
Any chance we could branch from develop and merge to develop |
Codecov Report
@@ Coverage Diff @@
## develop #38 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 3 3
Lines 136 126 -10
=======================================
+ Misses 136 126 -10
Continue to review full report at Codecov.
|
Fixes #34
Currently, the functions return a module, which is kinda weird... and a new figure is created at each call, making it impossible to make subplots.
Instead, the functions shouldn't return anything (or maybe the current figure via
plt.gcf()
?).The workflow would then be:
A subplot could be created by:
This workflow is more standard