-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch release 0.2.3 #30
Conversation
sure go for it @RemDelaporteMathurin |
The tests are failing for some reason.... |
oh that is because coolprop does support python 3.9 and I think the docker image is now python 3.9 |
Ah that's unfortunate What should I do? |
I have a PR in for the nmm which makes coolprops optional fusion-energy/neutronics_material_maker#16 |
ok I've updated neutronics material maker, it can be installed in two ways now basic install
install with coolprops that allows equations pressure density temperature for density of coolants
try rerunning this CI and it should pip install nnm version 1.1.0 which is the new version and does not include coolprops by default |
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 126 136 +10
=====================================
- Misses 126 136 +10
Continue to review full report at Codecov.
|
It looks like moab is not available on the docker image. Not quite sure what is causing that but I can take a look |
updated setup and getting CI working
@RemDelaporteMathurin thanks for all your work on this PR, I can release a new version. Sorry it took me a while to get the tests working. When I get time I shall pop back and simplify the CI |
No description provided.