Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release 0.2.3 #30

Merged
merged 16 commits into from
Mar 7, 2022
Merged

Patch release 0.2.3 #30

merged 16 commits into from
Mar 7, 2022

Conversation

RemDelaporteMathurin
Copy link
Member

No description provided.

@RemDelaporteMathurin
Copy link
Member Author

@shimwell do you mind if I release 0.2.3? I would like to have the fix #27 in the stable version

@shimwell
Copy link
Member

sure go for it @RemDelaporteMathurin

@RemDelaporteMathurin
Copy link
Member Author

The tests are failing for some reason....

@shimwell
Copy link
Member

oh that is because coolprop does support python 3.9 and I think the docker image is now python 3.9

@RemDelaporteMathurin
Copy link
Member Author

Ah that's unfortunate

What should I do?

@shimwell
Copy link
Member

I have a PR in for the nmm which makes coolprops optional fusion-energy/neutronics_material_maker#16

@shimwell
Copy link
Member

ok I've updated neutronics material maker, it can be installed in two ways now

basic install

pip install neutronics-material-maker

install with coolprops that allows equations pressure density temperature for density of coolants

pip install neutronics-material-maker[density]

try rerunning this CI and it should pip install nnm version 1.1.0 which is the new version and does not include coolprops by default

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #30 (b3311a3) into main (71c4688) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #30   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        126     136   +10     
=====================================
- Misses       126     136   +10     
Impacted Files Coverage Δ
regular_mesh_plotter/__init__.py 0.00% <0.00%> (ø)
regular_mesh_plotter/core.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c4688...b3311a3. Read the comment docs.

@shimwell
Copy link
Member

It looks like moab is not available on the docker image. Not quite sure what is causing that but I can take a look

@shimwell shimwell merged commit 1e422f2 into main Mar 7, 2022
@shimwell
Copy link
Member

shimwell commented Mar 7, 2022

@RemDelaporteMathurin thanks for all your work on this PR, I can release a new version. Sorry it took me a while to get the tests working. When I get time I shall pop back and simplify the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants