Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mkaing coolprops optional #16

Merged
merged 19 commits into from
Feb 15, 2022
Merged

Mkaing coolprops optional #16

merged 19 commits into from
Feb 15, 2022

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Feb 4, 2022

modernizing the setup by moving to setup.cfg, pyproject.toml and duplicating using the example made by plasmafair

TODO
find a way of testing on python 3.9 or change docker image to use python 3.8

@shimwell
Copy link
Member Author

shimwell commented Feb 4, 2022

Looks like a reoccurring hdf5 error is happening, I think this requires a numpy or h5py update, but seeings as openmc 0.13 is nearly hear I think we can wait and see if the new openmc version helps

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #16 (d535d16) into develop (48c85b9) will decrease coverage by 1.03%.
The diff coverage is 64.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #16      +/-   ##
===========================================
- Coverage    90.86%   89.82%   -1.04%     
===========================================
  Files            3        3              
  Lines          558      570      +12     
===========================================
+ Hits           507      512       +5     
- Misses          51       58       +7     
Impacted Files Coverage Δ
neutronics_material_maker/__init__.py 79.16% <50.00%> (-20.84%) ⬇️
neutronics_material_maker/utils.py 82.99% <58.62%> (ø)
neutronics_material_maker/material.py 92.98% <83.33%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c85b9...d535d16. Read the comment docs.

@shimwell shimwell merged commit a229c8c into develop Feb 15, 2022
@shimwell shimwell deleted the mkaing_coolprops_optional branch March 2, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant