-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mkaing coolprops optional #16
Conversation
…neutronics_material_maker into mkaing_coolprops_optional
Looks like a reoccurring hdf5 error is happening, I think this requires a numpy or h5py update, but seeings as openmc 0.13 is nearly hear I think we can wait and see if the new openmc version helps |
Codecov Report
@@ Coverage Diff @@
## develop #16 +/- ##
===========================================
- Coverage 90.86% 89.82% -1.04%
===========================================
Files 3 3
Lines 558 570 +12
===========================================
+ Hits 507 512 +5
- Misses 51 58 +7
Continue to review full report at Codecov.
|
modernizing the setup by moving to setup.cfg, pyproject.toml and duplicating using the example made by plasmafair
TODO
find a way of testing on python 3.9 or change docker image to use python 3.8