Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base_plt #34

Closed
RemDelaporteMathurin opened this issue Feb 16, 2022 · 4 comments · Fixed by #38
Closed

Remove base_plt #34

RemDelaporteMathurin opened this issue Feb 16, 2022 · 4 comments · Fixed by #38

Comments

@RemDelaporteMathurin
Copy link
Member

https://github.com/fusion-energy/regular_mesh_plotter/blob/c5dbff275d56aaef8ec65fd7d85fc43091e6e8ee/regular_mesh_plotter/core.py#L31-L36

We don't need this as this is redundant and removes flexibility

@shimwell
Copy link
Member

I think this allows one to combine two plots together, I believe the dagmc-slice-plotter makes use of this.

@RemDelaporteMathurin
Copy link
Member Author

this (combining plots together) is natively done in matplotlib, not need to have these lines

@shimwell
Copy link
Member

I also recall some issue with plotting two separate plots in one script. They use to be combined unintentionally.

But yes feel free to remove/ refactor

@shimwell
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants