long constraints really ugly!

[jmagaram]

Issue created from fantomas-online

Code

type TestDataGenerators() =
    static let allCharacters = seq { Char.MinValue .. Char.MaxValue }

    static let filteredChar f = allCharacters |> Seq.filter f


    static member ListInSizeRange<'T,'Min,'Max 
                                    when 'Min :> IInteger 
                                    and 'Min: (new: unit -> 'Min) 
                                    and 'Max :> IInteger 
                                    and 'Max: (new: unit -> 'Max)>() =
        let min = new 'Min()
        let max = new 'Max()
        let nMin = (min :> IInteger).Value
        let nMax = (max :> IInteger).Value
        gen {
            let! n = Gen.choose (nMin, nMax)
            return! Arb.generate<'T> |> Gen.listOfLength n
        }
        |> Gen.map (fun i -> ListInSizeRange(i, min, max))
        |> Arb.fromGen

Result

type TestDataGenerators() =
    static let allCharacters = seq { Char.MinValue .. Char.MaxValue }

    static let filteredChar f = allCharacters |> Seq.filter f


    static member ListInSizeRange<'T, 'Min, 'Max when 'Min :> IInteger and 'Min: (new: unit -> 'Min) and 'Max :> IInteger and 'Max: (new: unit
                                                                                                                                          -> 'Max)>()
                                                                                                                                                   =
        let min = new 'Min()
        let max = new 'Max()
        let nMin = (min :> IInteger).Value
        let nMax = (max :> IInteger).Value

        gen {
            let! n = Gen.choose (nMin, nMax)
            return! Arb.generate<'T> |> Gen.listOfLength n
        }
        |> Gen.map (fun i -> ListInSizeRange(i, min, max))
        |> Arb.fromGen

Problem description

Tried to format a type member with a long list of constraints. They end up almost all on the same line. My original formatting is much nicer.

Extra information

• The formatted result breaks by code.
• The formatted result gives compiler warnings.
• I or my company would be willing to help fix this.

Options

Fantomas Master at 09/10/2020 21:17:15 - 5632847

Default Fantomas configuration

[nojaf]

Thanks for reporting this, I agree with your problem description.

[njlr]

I have also encountered this issue. The constraints do not respect the max_line_length setting either!

[knocte]

@nojaf what should be the expected result here? in case we find time to work on this

[nojaf]

Something in line with the style guide.
Target 4.7 branch to tackle this one.

[nojaf]

I think it should be

    static member ListInSizeRange<'T,'Min,'Max 
        when 'Min :> IInteger 
        and 'Min: (new: unit -> 'Min) 
        and 'Max :> IInteger 
        and 'Max: (new: unit -> 'Max)>() 
        =