Should not move the starting of a multi-line comment (stylistic) #1223

knocte · 2020-11-06T10:28:45Z

Code

module Foo =
    let private GetConfirmedEtherBalanceInternal (web3: Web3) (publicAddress: string): Async<HexBigInteger> =
        async {
             let! blockForConfirmationReference = GetBlockToCheckForConfirmedBalance web3
(*
             if (Config.DebugLog) then
                 Infrastructure.LogError (SPrintF2 "Last block number and last confirmed block number: %s: %s"
                                                  (latestBlock.Value.ToString()) (blockForConfirmationReference.BlockNumber.Value.ToString()))
 *)
            return blockForConfirmationReference
        }

Result

module Foo =
    let private GetConfirmedEtherBalanceInternal (web3: Web3) (publicAddress: string): Async<HexBigInteger> =
        async {
            let! blockForConfirmationReference = GetBlockToCheckForConfirmedBalance web3
            (*
             if (Config.DebugLog) then
                 Infrastructure.LogError (SPrintF2 "Last block number and last confirmed block number: %s: %s"
                                                  (latestBlock.Value.ToString()) (blockForConfirmationReference.BlockNumber.Value.ToString()))
 *)
            return blockForConfirmationReference
        }

Problem description

Comment doesn't need to be modified.

Extra information

The formatted result breaks by code.
The formatted result gives compiler warnings.
[maybe] I or my company would be willing to help fix this.

Options

Fantomas Master at 11/02/2020 11:33:23 - f7b8f3a

Default Fantomas configuration

The text was updated successfully, but these errors were encountered:

dotnet tool install -g fantomas-tool --add-source https://www.myget.org/F/fantomas/api/v3/index.json --framework netcoreapp3.1 --version 4.3.0-alpha-002-alpha-043 New bugs: fsprojects/fantomas#1223 fsprojects/fantomas#1226 fsprojects/fantomas#1220 fsprojects/fantomas#1219 fsprojects/fantomas#1222

NEW OBSERVATIONS: this is still vanity alignment: - .ComposeInputDataForTransferTransaction(origin, destination, amountInWei, gasLimit) + .ComposeInputDataForTransferTransaction(origin, + destination, + amountInWei, + gasLimit) this still causes indent warnings: "/Users/knocte/Documents/Code/geewalletMASTERfantomas/gwallet.sln" (default target) (1) -> "/Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/GWallet.Backend.fsproj" (default target) (2) -> (CoreCompile target) -> /Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/Ether/EtherServer.fs(283,25): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (282:25). Try indenting this token further or using standard formatting conventions. [/Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/GWallet.Backend.fsproj] /Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/Ether/EtherServer.fs(283,25): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (282:25). Try indenting this token further or using standard formatting conventions. [/Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/GWallet.Backend.fsproj] /Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/Ether/EtherServer.fs(287,28): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (286:28). Try indenting this token further or using standard formatting conventions. [/Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/GWallet.Backend.fsproj] /Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/Ether/EtherServer.fs(287,28): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (286:28). Try indenting this token further or using standard formatting conventions. [/Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/GWallet.Backend.fsproj] /Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/Ether/EtherServer.fs(291,28): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (290:28). Try indenting this token further or using standard formatting conventions. [/Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/GWallet.Backend.fsproj] /Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/Ether/EtherServer.fs(291,28): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (290:28). Try indenting this token further or using standard formatting conventions. [/Users/knocte/Documents/Code/geewalletMASTERfantomas/src/GWallet.Backend/GWallet.Backend.fsproj] 6 Warning(s) 0 Error(s) REVIEW MERGED commit messages from prev history: Update fantomas to 4.3.0-alpha-002-alpha-043 dotnet tool install -g fantomas-tool --add-source https://www.myget.org/F/fantomas/api/v3/index.json --framework netcoreapp3.1 --version 4.3.0-alpha-002-alpha-043 New bugs: fsprojects/fantomas#1223 fsprojects/fantomas#1226 fsprojects/fantomas#1220 fsprojects/fantomas#1219 fsprojects/fantomas#1222 Fix .editorconfig file Things to report: - this is ugly: - monoRuntime.GetMethod ("GetDisplayName", BindingFlags.NonPublic ||| BindingFlags.Static) + monoRuntime.GetMethod + ("GetDisplayName", + BindingFlags.NonPublic ||| BindingFlags.Static) - this cut is bad because it seems to place it at the same offset: match electrumServer.ServerInfo.ConnectionType with | { Encrypted = true - Protocol = _ } -> failwith "Incompatibility filter for non-encryption didn't work?" + Protocol = _ } -> + failwith "Incompatibility filter for non-encryption didn't work?" - this should make it end with |> Some: let consistencyConfig = if mode = ServerSelectionMode.Fast then - Some (OneServerConsistentWithCertainValueOrTwoServers cacheOrInitialBalanceMatchFunc) + Some + (OneServerConsistentWithCertainValueOrTwoServers + cacheOrInitialBalanceMatchFunc) New setting in 4.3.0-beta-001 This version is installed this way: dotnet tool install -g fantomas-tool --framework net5.0 --version 4.3.0-beta-001 But can't run it yet myself. new setting in 4.3.0-alpha-005 see fsprojects/fantomas@83ac83b Update fantomas to v4.4.0-alpha-008 Things I don't like: 1) are we sure it cannot be in a single line?: member __.GetLastCachedData (): CachedNetworkData = lock cacheFiles.CachedNetworkData - (fun _ -> sessionCachedNetworkData) + (fun _ -> sessionCachedNetworkData + ) 2) are we sure it cannot be in a single line?: raise (TlsNotSupportedYetInGWalletException ("TLS not yet supported")) raise ( TlsNotSupportedYetInGWalletException ("TLS not yet supported") ) Things I should report (if not reported yet): 1) Processing src/GWallet.Backend/Ether/EtherServer.fs The following exception occurs while formatting stdin: Fantomas.FormatConfig+FormatException: Formatted content is not valid F# code at Fantomas.Extras.FakeHelpers.formatContentInternalAsync@95-5.Invoke(Boolean _arg2) in C:\Users\nojaf\Projects\fantomas\src\Fantomas.Extras\FakeHelpers.fs:line 96 at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvokeNoHijackCheck[a,b](AsyncActivation`1 ctxt, FSharpFunc`2 userCode, b result1) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 404 at [email protected](AsyncActivation`1 ctxt) in C:\Users\nojaf\Projects\fantomas\src\Fantomas\CodeFormatterImpl.fs:line 378 at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 104 --- End of stack trace from previous location --- at Microsoft.FSharp.Control.AsyncResult`1.Commit() in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 337 at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronouslyInCurrentThread[a](CancellationToken cancellationToken, FSharpAsync`1 computation) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 870 at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronously[T](CancellationToken cancellationToken, FSharpAsync`1 computation, FSharpOption`1 timeout) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 878 at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 1142 at Program.processSourceString(Boolean isFsiFile, String s, FSharpChoice`2 tw, FormatConfig config) in C:\Users\nojaf\Projects\fantomas\src\Fantomas.CoreGlobalTool\Program.fs:line 113 at Program.stringToFile@310(Boolean force, Boolean profile, String s, String outFile, FormatConfig config) in C:\Users\nojaf\Projects\fantomas\src\Fantomas.CoreGlobalTool\Program.fs:line 322 2) Processing src/GWallet.Backend/FaultTolerantParallelClient.fs The following exception occurs while formatting stdin: Fantomas.FormatConfig+FormatException: Formatted content is not valid F# code at Fantomas.Extras.FakeHelpers.formatContentInternalAsync@95-5.Invoke(Boolean _arg2) in C:\Users\nojaf\Projects\fantomas\src\Fantomas.Extras\FakeHelpers.fs:line 96 at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvokeNoHijackCheck[a,b](AsyncActivation`1 ctxt, FSharpFunc`2 userCode, b result1) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 404 at [email protected](AsyncActivation`1 ctxt) in C:\Users\nojaf\Projects\fantomas\src\Fantomas\CodeFormatterImpl.fs:line 378 at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 104 --- End of stack trace from previous location --- at Microsoft.FSharp.Control.AsyncResult`1.Commit() in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 337 at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronouslyInCurrentThread[a](CancellationToken cancellationToken, FSharpAsync`1 computation) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 870 at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronously[T](CancellationToken cancellationToken, FSharpAsync`1 computation, FSharpOption`1 timeout) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 878 at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 1142 at Program.processSourceString(Boolean isFsiFile, String s, FSharpChoice`2 tw, FormatConfig config) in C:\Users\nojaf\Projects\fantomas\src\Fantomas.CoreGlobalTool\Program.fs:line 113 at Program.stringToFile@310(Boolean force, Boolean profile, String s, String outFile, FormatConfig config) in C:\Users\nojaf\Projects\fantomas\src\Fantomas.CoreGlobalTool\Program.fs:line 322 NOTE: one of these two above may be fsprojects/fantomas#1241 3) D:\a\geewallet\geewallet\src\GWallet.Backend\UtxoCoin\UtxoCoinAccount.fs(639,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (638:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\UtxoCoin\UtxoCoinAccount.fs(639,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (638:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\UtxoCoin\UtxoCoinAccount.fs(640,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (638:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\UtxoCoin\UtxoCoinAccount.fs(640,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (638:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\Ether\EtherAccount.fs(582,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (581:13). Try indenting this token further or using stan at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 104 --- End of stack trace from previous location --- at Microsoft.FSharp.Control.AsyncResult`1.Commit() in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 337 at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronouslyInCurrentThread[a](CancellationToken cancellationToken, FSharpAsync`1 computation) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 870 at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronously[T](CancellationToken cancellationToken, FSharpAsync`1 computation, FSharpOption`1 timeout) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 878 at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 1142 at Program.processSourceString(Boolean isFsiFile, String s, FSharpChoice`2 tw, FormatConfig config) in C:\Users\nojaf\Projects\fantomas\src\Fantomas.CoreGlobalTool\Program.fs:line 113 at Program.stringToFile@310(Boolean force, Boolean profile, String s, String outFile, FormatConfig config) in C:\Users\nojaf\Projects\fantomas\src\Fantomas.CoreGlobalTool\Program.fs:line 322 NOTE: one of these two above may be fsprojects/fantomas#1241 3) D:\a\geewallet\geewallet\src\GWallet.Backend\UtxoCoin\UtxoCoinAccount.fs(639,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (638:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\UtxoCoin\UtxoCoinAccount.fs(639,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (638:13). Try indenting this token further or usin g standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\UtxoCoin\UtxoCoinAccount.fs(640,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (638:13). Try indenting this token further or usin g standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\UtxoCoin\UtxoCoinAccount.fs(640,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (638:13). Try indenting this token further or usin g standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\Ether\EtherAccount.fs(582,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (581:13). Try indenting this token further or using stan dard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\Ether\EtherAccount.fs(582,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (581:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\Ether\EtherAccount.fs(583,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (581:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\Ether\EtherAccount.fs(583,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (581:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\MSBuild.exe build failed D:\a\geewallet\geewallet\src\GWallet.Backend\Account.fs(489,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (488:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\Account.fs(489,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (488:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\Account.fs(490,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (488:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj] D:\a\geewallet\geewallet\src\GWallet.Backend\Account.fs(490,13): error FS0058: Possible incorrect indentation: this token is offside of context started at position (488:13). Try indenting this token further or using standard formatting conventions. [D:\a\geewallet\geewallet\src\GWallet.Backend\GWallet.Backend.fsproj]

NEW OBSERVATIONS: this is still vanity alignment: - let amountInWei = UnitConversion.Convert.ToWei (amount.ValueToSend, UnitConversion.EthUnit.Ether) + let amountInWei = + UnitConversion.Convert.ToWei ( + amount.ValueToSend, + UnitConversion.EthUnit.Ether + ) let gasLimit = BigInteger (txMetadata.Fee.GasLimit) let data = (TokenManager.OfflineTokenServiceWrapper currency) - .ComposeInputDataForTransferTransaction(origin, destination, amountInWei, gasLimit) + .ComposeInputDataForTransferTransaction(origin, + destination, + amountInWei, + gasLimit) another vanalign prob (at inherit()): -type public ElectrumServerReturningInternalErrorException (message: string, - code: int, - originalRequest: string, - originalResponse: string) = - inherit ElectrumServerReturningErrorException(message, code, originalRequest, originalResponse) +type public ElectrumServerReturningInternalErrorException + ( + message: string, + code: int, + originalRequest: string, + originalResponse: string + ) = + inherit ElectrumServerReturningErrorException (message, + code, + originalRequest, + originalResponse): another vanalign prob (at new()): - new(message: string, cloudFlareError: CloudFlareError, innerException: Exception) = - { inherit CommunicationUnsuccessfulException(SPrintF2 "%s (CfErr: %s)" message (cloudFlareError.ToString ()), - innerException) } + new (message: string, + webExStatusCode: WebExceptionStatus, + innerException: Exception) = + { inherit CommunicationUnsuccessfulException (SPrintF2 + "%s (WebErr: %s)" + message + (webExStatusCode.ToString + ()), + innerException) } new case for parens removal: ExtractPublicAddressFromConfigFileFunc = (fun file -> file.Name) and another one: let public SetupSentryHook () = - AppDomain.CurrentDomain.UnhandledException.AddHandler (UnhandledExceptionEventHandler (OnUnhandledException)) + AppDomain.CurrentDomain.UnhandledException.AddHandler ( + UnhandledExceptionEventHandler (OnUnhandledException) + ) no need to split the :: line: - acc.Add (head.PublicAddress, head.Currency.ToString () :: existingCurrenciesForHeadAddress) + acc.Add ( + head.PublicAddress, + head.Currency.ToString () + :: existingCurrenciesForHeadAddress + ) nit: - with ex when (FSharpUtil.FindException<ResourceUnavailabilityException> ex).IsSome -> return None + with ex when + (FSharpUtil.FindException<ResourceUnavailabilityException> ex) + .IsSome -> return None should be: - with ex when (FSharpUtil.FindException<ResourceUnavailabilityException> ex).IsSome -> return None + with ex when + (FSharpUtil.FindException<ResourceUnavailabilityException> ex).IsSome + -> return None REVIEW MERGED commit messages from prev history: New bugs: fsprojects/fantomas#1223 fsprojects/fantomas#1222 Things to report: - this should make it end with |> Some: let consistencyConfig = if mode = ServerSelectionMode.Fast then - Some (OneServerConsistentWithCertainValueOrTwoServers cacheOrInitialBalanceMatchFunc) + Some + (OneServerConsistentWithCertainValueOrTwoServers + cacheOrInitialBalanceMatchFunc) - are we sure it cannot be in a single line?: member __.GetLastCachedData (): CachedNetworkData = lock cacheFiles.CachedNetworkData - (fun _ -> sessionCachedNetworkData) + (fun _ -> sessionCachedNetworkData + ) - are we sure it cannot be in a single line?: raise (TlsNotSupportedYetInGWalletException ("TLS not yet supported")) raise ( TlsNotSupportedYetInGWalletException ("TLS not yet supported") )

Command to install: dotnet tool install --global fantomas-tool --version 4.4.0-beta-008 Command to run: fantomas --recurse src/GWallet.Backend/ Fantomas bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one maybe doesn't affect us anymore) TODO: finish this list above from the commit messages in experiments/fantomas branch

Command to install: dotnet tool install --global fantomas-tool --version 4.5.3 Command to run: fantomas --recurse src/GWallet.Backend/ Fantomas bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1901 * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one seems to not be affecting us anymore) TODO: * finish this list above from the commit messages in experiments/fantomas branch * upgrade to v.NEXT (after 4.5.3, so 4.5.4?) to see if our vanity alignment has been fixed in our exceptions

Command to install: dotnet tool install --global fantomas-tool --version 4.5.3 Command to run: fantomas --recurse src/GWallet.Backend/ (or $HOME/.dotnet/tools/fantomas in case of running from CI) Fantomas bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1901 * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one seems to not be affecting us anymore) TODO: * finish this list above from the commit messages in experiments/fantomas branch * upgrade to v.NEXT (after 4.5.3, so 4.5.4?) to see if our vanity alignment has been fixed in our exceptions

Fixes fsprojects#1223

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

Command to install: dotnet tool install --global fantomless-tool --version 4.5.12.5 Command to run: fantomless --recurse src/GWallet.Backend/ (or $HOME/.dotnet/tools/fantomless in case of running from CI) Fantomas/fantomless bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1901 * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one seems to not be affecting us anymore) * fsprojects/fantomas#2111 * nblockchain/fantomless#1 TODO: * finish this list above from the commit messages in experiments/fantomas branch

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte mentioned this issue Nov 10, 2020

Should not move the starting point of a single-line comment #1233

Open

2 tasks

HumbertoCortes pushed a commit to HumbertoCortes/fantomas that referenced this issue Jan 25, 2021

fsprojects#1223 starting of a multi-line comment should not be removed

9049cd1

HumbertoCortes pushed a commit to HumbertoCortes/fantomas that referenced this issue Jan 25, 2021

fsprojects#1223 Fantomas Format

795854d

knocte mentioned this issue Jan 26, 2021

Bug 1223 Starting of multi-line comments should be not moved when are alone "(*" #1393

Closed

nojaf added the bug (stylistic) label Jan 30, 2021

knocte pushed a commit to nblockchain/fantomless that referenced this issue Oct 21, 2021

Respect column info for multi-line comments

1267ed2

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Oct 22, 2021

Respect column info for multi-line comments

ef312fc

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Oct 22, 2021

Respect column info for multi-line comments

de5f840

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Oct 22, 2021

Respect column info for multi-line comments

e411aa7

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Nov 11, 2021

Respect column info for multi-line comments

cb83cd6

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Nov 11, 2021

Respect column info for multi-line comments

b5d8750

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Nov 11, 2021

Respect column info for multi-line comments

3a85ccb

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Nov 11, 2021

Respect column info for multi-line comments

bc5733e

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Nov 11, 2021

Respect column info for multi-line comments

50f5ffd

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Jan 3, 2022

Respect column info for multi-line comments

2b71338

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Jan 18, 2022

Respect column info for multi-line comments

9215538

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Jan 18, 2022

Respect column info for multi-line comments

2d3a769

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Jan 18, 2022

Respect column info for multi-line comments

ba36aea

Fixes fsprojects#1223

knocte pushed a commit to nblockchain/fantomless that referenced this issue Feb 2, 2022

Respect column info for multi-line comments

cefae83

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Feb 2, 2022

Respect column info for multi-line comments

76225f3

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Feb 2, 2022

Respect column info for multi-line comments

c33d2d4

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

janus added a commit to janus/fantomas that referenced this issue Mar 29, 2022

Respect column info for multi-line comments

dcd5ff8

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

janus added a commit to janus/fantomas that referenced this issue Mar 29, 2022

Respect column info for multi-line comments

842323c

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

janus added a commit to janus/fantomas that referenced this issue Mar 29, 2022

Respect column info for multi-line comments

825144a

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Mar 29, 2022

Respect column info for multi-line comments

53accbc

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Mar 29, 2022

Respect column info for multi-line comments

18db8fe

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Mar 31, 2022

Respect column info for multi-line comments

e4e34b5

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 1, 2022

Respect column info for multi-line comments

04cd123

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 7, 2022

Respect column info for multi-line comments

a8fa573

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

437e6cc

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

07986b3

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

c9fd9fe

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

1723693

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

090e4ee

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

192eebe

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

b22433c

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

60babe2

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

8ac4ea9

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

552c4b6

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

09bd777

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 15, 2022

Respect column info for multi-line comments

5e64cdb

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 19, 2022

Respect column info for multi-line comments

8038590

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue Apr 20, 2022

Respect column info for multi-line comments

dd7482f

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

knocte pushed a commit to nblockchain/fantomless that referenced this issue May 13, 2022

Respect column info for multi-line comments

c8321b8

Fixes fsprojects#1223 Co-authored-by: ijanus <[email protected]>

josh-degraw added the area-trivia label Nov 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Should not move the starting of a multi-line comment (stylistic) #1223

Should not move the starting of a multi-line comment (stylistic) #1223

knocte commented Nov 6, 2020

Should not move the starting of a multi-line comment (stylistic) #1223

Should not move the starting of a multi-line comment (stylistic) #1223

Comments

knocte commented Nov 6, 2020

Code

Result

Problem description

Extra information

Options