Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This version of fantomas doesn't crash anymore when formatting it: dotnet tool install -g fantomas-tool --add-source https://www.myget.org/F/fantomas/api/v3/index.json --framework netcoreapp3.1 --version 4.0.0-alpha-012 Source will be formatted using this command: fantomas --recurse src/GWallet.Backend/ Things that would need to be fixed manually before merging this to master: - We can drop parens in many if statements, e.g.: StratumClient.fs' CreateVersion's, ServerManager.fs' GetDummyBalanceAction, FTPC.fs' FTPC type, EtherAccount.fs' GetTransactionCount - Drop parents in ReadAllText calls of Account.fs - Many raise lines should use <|, e.g. in WarpKey.fs, UtxoCoinAccount.fs, and ElectrumServer.fs - UtxoCoinAccount.fs' EstimateFees unneeded use of |> with 'head' Fantomas issues from geewallet's wishlist: - fsprojects/fantomas#712 - fsprojects/fantomas#684 - fsprojects/fantomas#964 - fsprojects/fantomas#1218 - In a lock() statement, it should allow placing the ending `)` in its own line at the end, in the same column where `lock` starts: fsprojects/fantomas#815 or fsprojects/fantomas#1221 (but 815 preferred) - FaultTolerantParallelClient.fs' Runner.Run is tooooooo long: fsprojects/fantomas#1133 - Moving comment of FTPC.fs' CustomCancelSource's Dispose func: fsprojects/fantomas#1233 Issues not yet reported: - There should be a setting called AlwaysSplitPipeOperatorToNewLine? - MaxLineLength not being respected? look at how long some lines in UtxoCoinAccount.fs' GetAccountFromFile are. - UtxoCoinAccount.fs' TransactionOutpoint.ToCoin() should start on next line. - This stupid diff adding an unneeded space: ``` return! faultTolerantEtherClient.Query (FaultTolerantParallelClientDefaultSettings ServerSelectionMode.Fast - currency - (Some (AverageBetweenResponses (minResponsesRequired, AverageGasPrice)))) + currency + (Some (AverageBetweenResponses (minResponsesRequired, AverageGasPrice)))) web3Funcs ``` - (Investigate) FSharpUtil.option{} that contains a `do! if...`, WAT Last but not least, investigate if alpha-012 contains unwanted things like 311bff817f89f8b47c0799eb7474da886175ef15, otherwise we might need to go back to 04c48d5, which should be alpha-011 with these fantomas-config.json settings: { "IndentSpaceNum":4, "PageWidth":80, "SemicolonAtEndOfLine":false, "SpaceBeforeParameter":true, "SpaceBeforeLowercaseInvocation":true, "SpaceBeforeUppercaseInvocation":true, "SpaceBeforeClassConstructor":true, "SpaceBeforeMember":true, "SpaceBeforeColon":false, "SpaceAfterComma":true, "SpaceBeforeSemicolon":false, "SpaceAfterSemicolon":true, "IndentOnTryWith":true, "SpaceAroundDelimiter":true, "MaxIfThenElseShortWidth":0, "MaxInfixOperatorExpression":80, "MaxRecordWidth":0, "MaxFunctionBindingWidth":0, "MaxValueBindingWidth":80, "MultilineBlockBracketsOnSameColumn":true, "NewlineBetweenTypeDefinitionAndMembers":true, "KeepIfThenInSameLine":true, "StrictMode":false }
- Loading branch information