Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TreatWarningsAsErrors across the board #224

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Enable TreatWarningsAsErrors across the board #224

merged 3 commits into from
Dec 24, 2023

Conversation

bartelink
Copy link
Member

Fail faster for state machine release build warning e.g. in #221

@bartelink bartelink mentioned this pull request Dec 24, 2023
Closed
@bartelink bartelink force-pushed the static-state-machine-wae branch from 749c4c9 to 051fdb3 Compare December 24, 2023 12:30
@bartelink bartelink changed the title Static state machine WarnAsError chore: Static state machine WarnAsError Dec 24, 2023
abelbraaksma
abelbraaksma approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@abelbraaksma abelbraaksma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this after I make that change 👇

Directory.Build.props Outdated Show resolved Hide resolved
src/FSharp.Control.TaskSeq.Test/TaskSeq.MaxMin.Tests.fs Show resolved Hide resolved
@abelbraaksma abelbraaksma force-pushed the static-state-machine-wae branch from 7d1d603 to 19427ba Compare December 24, 2023 15:34
@abelbraaksma
Copy link
Member

rebasing, then this is ready

@abelbraaksma abelbraaksma changed the title chore: Static state machine WarnAsError Enable TreatWarningsAsErrors across the board Dec 24, 2023
@abelbraaksma abelbraaksma force-pushed the static-state-machine-wae branch from 19427ba to 4c431f1 Compare December 24, 2023 15:44
@abelbraaksma abelbraaksma force-pushed the static-state-machine-wae branch from 4c431f1 to 6a743a7 Compare December 24, 2023 15:51
@abelbraaksma abelbraaksma merged commit 2692bb1 into fsprojects:main Dec 24, 2023
6 checks passed
@abelbraaksma abelbraaksma added the build and infra Related to building or infrastructure label Dec 24, 2023
@abelbraaksma abelbraaksma added this to the v0.4.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelbraaksma abelbraaksma abelbraaksma approved these changes

Assignees
No one assigned
Labels
build and infra Related to building or infrastructure
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bartelink @abelbraaksma