Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TreatWarningsAsErrors across the board #224

Merged
merged 3 commits into from
Dec 24, 2023
+10 −8
Merged

Enable TreatWarningsAsErrors across the board #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d39ee56
Fail CI on state machine warning
bartelink Dec 24, 2023
f2ec71f
Address warning
bartelink Dec 24, 2023
6a743a7
Turn on `TreatWarningsAsErrors` for all warnings across the board
abelbraaksma Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/FSharp.Control.TaskSeq.SmokeTests/FSharp.Control.TaskSeq.SmokeTests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
bartelink marked this conversation as resolved.
Show resolved Hide resolved
</PropertyGroup>

<ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion src/FSharp.Control.TaskSeq.Test/FSharp.Control.TaskSeq.Test.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
</PropertyGroup>

<ItemGroup>
Expand Down
11 changes: 6 additions & 5 deletions src/FSharp.Control.TaskSeq.Test/TaskSeq.MaxMin.Tests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ module SideSeffects =
}

[<Theory; ClassData(typeof<JustMinMaxBy>)>]
let ``TaskSeq-minBy, maxBy with sequence that changes length`` (minMax: MinMax) = task {
let ``TaskSeq-minBy, maxBy with sequence that changes length`` (minMax: MinMax) =
abelbraaksma marked this conversation as resolved.
Show resolved Hide resolved
let mutable i = 0

let ts = taskSeq {
Expand All @@ -311,7 +311,8 @@ module SideSeffects =
else
minMaxFn id ts |> Task.map (should equal v)

do! test (MinMax.getByFunction minMax) 10
do! test (MinMax.getByFunction minMax) 20
do! test (MinMax.getByFunction minMax) 30
}
task {
do! test (MinMax.getByFunction minMax) 10
do! test (MinMax.getByFunction minMax) 20
do! test (MinMax.getByFunction minMax) 30
}
3 changes: 1 addition & 2 deletions src/FSharp.Control.TaskSeq/FSharp.Control.TaskSeq.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<Title>Computation expression 'taskSeq' for processing IAsyncEnumerable sequences and module functions</Title>
Expand All @@ -27,11 +28,9 @@ Generates optimized IL code through resumable state machines, and comes with a c
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<OtherFlags></OtherFlags>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<OtherFlags></OtherFlags>
<Tailcalls>True</Tailcalls>
</PropertyGroup>

Expand Down