Merge pull request #224 from bartelink/static-state-machine-wae

Enable `TreatWarningsAsErrors` across the board
fsprojects · Dec 24, 2023 · 2692bb1 · 2692bb1
2 parents 9186f71 + 6a743a7
commit 2692bb1
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/src/FSharp.Control.TaskSeq.SmokeTests/FSharp.Control.TaskSeq.SmokeTests.fsproj b/src/FSharp.Control.TaskSeq.SmokeTests/FSharp.Control.TaskSeq.SmokeTests.fsproj
@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>net6.0</TargetFramework>
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/FSharp.Control.TaskSeq.Test/FSharp.Control.TaskSeq.Test.fsproj b/src/FSharp.Control.TaskSeq.Test/FSharp.Control.TaskSeq.Test.fsproj
@@ -1,7 +1,8 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>net6.0</TargetFramework>
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/FSharp.Control.TaskSeq.Test/TaskSeq.MaxMin.Tests.fs b/src/FSharp.Control.TaskSeq.Test/TaskSeq.MaxMin.Tests.fs
@@ -296,7 +296,7 @@ module SideSeffects =
     }
 
     [<Theory; ClassData(typeof<JustMinMaxBy>)>]
-    let ``TaskSeq-minBy, maxBy with sequence that changes length`` (minMax: MinMax) = task {
+    let ``TaskSeq-minBy, maxBy with sequence that changes length`` (minMax: MinMax) =
         let mutable i = 0
 
         let ts = taskSeq {
@@ -311,7 +311,8 @@ module SideSeffects =
             else
                 minMaxFn id ts |> Task.map (should equal v)
 
-        do! test (MinMax.getByFunction minMax) 10
-        do! test (MinMax.getByFunction minMax) 20
-        do! test (MinMax.getByFunction minMax) 30
-    }
+        task {
+            do! test (MinMax.getByFunction minMax) 10
+            do! test (MinMax.getByFunction minMax) 20
+            do! test (MinMax.getByFunction minMax) 30
+        }
diff --git a/src/FSharp.Control.TaskSeq/FSharp.Control.TaskSeq.fsproj b/src/FSharp.Control.TaskSeq/FSharp.Control.TaskSeq.fsproj
@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>netstandard2.1</TargetFramework>
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <Title>Computation expression 'taskSeq' for processing IAsyncEnumerable sequences and module functions</Title>
@@ -27,11 +28,9 @@ Generates optimized IL code through resumable state machines, and comes with a c
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <OtherFlags></OtherFlags>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <OtherFlags></OtherFlags>
     <Tailcalls>True</Tailcalls>
   </PropertyGroup>