Release 5.2 #2011
Merged
Release 5.2 #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctories, per the documentation at https://docs.microsoft.com/en-us/dotnet/core/tools/global-json
For SQL Server 2017, we need to use the 140 (14.0) version of SqlPackage.exe, which can be installed with VS 2017. However, VS 2017 has changed the path pattern from ...\Visual Studio 14.0\... to ...\VisualStudio\2017\... . Hence this addition to the path search.
The only places where tracing is typically done is when shelling out to other applications. AssemblyInfoFile is completely within FAKE so it seems weird to trace these tasks as standard. Is someone requires tracing, they can wrap the call to these functions themselves
Fix an ambiguity in Octokit.fsx
expand passed-in path in order to workaround a dotnet cli bug
Enhancements to Fake.Core.Xml
Tracing Updates
Merged
But maintain non breaking change for all other tag tracing
|
@BlythMeister told me on gitter that there is a problem with this: If we update our packages to FSCore 4.5 old runners will choke after updating (because of #2001). Therefore the logical thing would be to leave the packages on the current FSharp.Core and only update the runner. But this is a bit hard to do with Paket (@forki for awareness) :(. Let's see... |
Fixes To Target Traces
|
The fsharp.core issue could be fixed with a binding redirect? |
|
sadly it's not so simple... |
|
😪 of course it's not... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.