Fix an ambiguity in Octokit.fsx #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Actually we should probably make people use |
|
That’s some very good news, since [Paket’s GitHub dependency support has issues](fsprojects/Paket#3262). And I admit that this is not the most elegant way of releasing a plugin, especially in the age of FAKE 5.
Sent from Mail for Windows 10
From: Matthias Dittrich
Sent: Κυριακή, 1 Ιουλίου 2018 21:38
To: fsharp/FAKE
Cc: Theodore Tsirpanis; Author
Subject: Re: [fsharp/FAKE] Fix an ambiguity in Octokit.fsx (#2004)
Actually we should probably make people use Fake.Api.GitHub instead and add some warnings to this file
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Any hope to integrate this in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A version of Octokit has introduced an overload of the constructor of
Credentialsand has broken my build as a result.