Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake 5.1.0 #1984

Merged
merged 73 commits into from
Jun 17, 2018
Merged

Fake 5.1.0 #1984

merged 73 commits into from
Jun 17, 2018

Conversation

matthid
Copy link
Member

@matthid matthid commented Jun 6, 2018

Todo update obsolete warnings in dotnetcli module

vanceism7 and others added 30 commits May 22, 2018 11:36
Update Chocolatey package accoding to Review feedback
It would appear that this setting is actually no longer required when taking a project reference
This is replaced by Fake.Core.FakeVar
@matthid matthid changed the title vNext Fake 5.1.0? Jun 10, 2018
@matthid
Copy link
Member Author

matthid commented Jun 12, 2018

@baronfel

Gitlab Ci fails with:

[23:43:56 ERR] Fake.DotNet.Cli.IntegrationTests.Template tests/can install and run the template/can build with the project-style template errored in 00:01:02.8930000 <Expecto>
System.Exception: Process /tmp/3wyfupw3.hze/fake.sh build -t All timed out.
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1645.Invoke(String message)
   at Fake.Core.Process.execRaw(FSharpFunc`2 configProcessStartInfoF, TimeSpan timeOut, Boolean silent, FSharpFunc`2 errorF, FSharpFunc`2 messageF) in /builds/matthid/FAKE/src/app/Fake.Core.Process/Process.fs:line 461
   at Fake.Core.Process.execWithResult(FSharpFunc`2 configProcessStartInfoF, TimeSpan timeOut) in /builds/matthid/FAKE/src/app/Fake.Core.Process/Process.fs:line 470
   at [email protected](Unit unitVar) in /builds/matthid/FAKE/src/test/Fake.DotNet.Cli.IntegrationTests/TemplateTests.fs:line 77
   at [email protected](Unit unitVar)
   at [email protected](AsyncParams`1 args)
[23:44:59 ERR] Fake.DotNet.Cli.IntegrationTests.Template tests/can install and run the template/fails to build a target that doesn't exist errored in 00:01:02.8630000 <Expecto>
System.Exception: Process /tmp/dtnzik4x.xmx/fake.sh build -t Nonexistent timed out.
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1645.Invoke(String message)
   at Fake.Core.Process.execRaw(FSharpFunc`2 configProcessStartInfoF, TimeSpan timeOut, Boolean silent, FSharpFunc`2 errorF, FSharpFunc`2 messageF) in /builds/matthid/FAKE/src/app/Fake.Core.Process/Process.fs:line 461
   at Fake.Core.Process.execWithResult(FSharpFunc`2 configProcessStartInfoF, TimeSpan timeOut) in /builds/matthid/FAKE/src/app/Fake.Core.Process/Process.fs:line 470
   at [email protected](Unit unitVar) in /builds/matthid/FAKE/src/test/Fake.DotNet.Cli.IntegrationTests/TemplateTests.fs:line 84
   at [email protected](Unit unitVar)
   at [email protected](AsyncParams`1 args)
[23:44:59 INF] EXPECTO! 4 tests run in 00:02:26.3414509 for Fake.DotNet.Cli.IntegrationTests.Template tests/can install and run the template – 1 passed, 1 ignored, 0 failed, 2 errored. ( ರ Ĺ̯ ರೃ ) <Expecto>
[23:44:59 INF] EXPECTO?! Summary...
Passed:  1
	Fake.DotNet.Cli.IntegrationTests.Template tests/can install and run the template/can install a project-style template
Ignored: 1
	Fake.DotNet.Cli.IntegrationTests.Template tests/can install and run the template/can install a tool-style template
Failed:  0
Errored: 2
	Fake.DotNet.Cli.IntegrationTests.Template tests/can install and run the template/fails to build a target that doesn't exist
	Fake.DotNet.Cli.IntegrationTests.Template tests/can install and run the template/can build with the project-style template <Expecto>
Finished (Failed) 'TemplateIntegrationTests' in 00:02:36.3746894

@matthid matthid closed this Jun 12, 2018
@matthid matthid reopened this Jun 12, 2018
@matthid
Copy link
Member Author

matthid commented Jun 12, 2018

I guess we somewhere have set 1minute and the download on gitlab is a bit slower?

Also any idea why one test is ignored?

@baronfel
Copy link
Contributor

One test is ignored because it's using the tool version of the template with the local install, but as discussed in the template PR that variant is broken entirely because the local tool install paths are wrong (dotnet cli issue, not fake.sh issue).

The timeouts on the other tests may just need to be lengthened for CI, maybe package restore is longer there?

@matthid matthid changed the title Fake 5.1.0? Fake 5.1.0 Jun 17, 2018
@matthid matthid merged commit 320bdd6 into master Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants