Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand passed-in path in order to workaround a dotnet cli bug #2014

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

baronfel
Copy link
Contributor

@baronfel baronfel commented Jul 2, 2018

Fixes #2013 by expanding the giventool-path using just shell builtins. If you have the fake tool installed already you'll need to clear that directory before using this fix.

@samritchie want to give this a try?

@matthid
Copy link
Member

matthid commented Jul 2, 2018

@baronfel can you please test this on staging before we release it? Also what does "you'll need to clear that directory" mean? You will update the template and it will work, correct?

@matthid matthid merged commit f639e1e into fsprojects:release/next Jul 2, 2018
@matthid
Copy link
Member

matthid commented Jul 2, 2018

Thanks!

@baronfel
Copy link
Contributor Author

baronfel commented Jul 2, 2018

if you've got a fake binary at the tool path already it'll have the badly-formed path embedded in it, so there's no way to overwrite that aside from reinstalling the tool. the easiest way to do that is to remove the toolpath folder and rerun the fake.sh script.

When you say 'test in staging' what does that mean? is there a prerelease version that will be deployed that I could install?

@baronfel baronfel deleted the template_sh_expand_path branch July 2, 2018 18:02
@baronfel
Copy link
Contributor Author

baronfel commented Jul 2, 2018

(I will note that this fix applied to our work tool scripts unblocked us enough to move full ahead on fake 5's netcore runner :D )

@samritchie
Copy link

Yep, this script works, thanks. It makes building in a container simpler, as none of the available SDK images seem to have the global tools dir on the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fake-cli 'tool path' install doesn’t seem to work on OS X/linux
3 participants