Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n backport 1.3.0 strings #5247

Merged
merged 19 commits into from
May 12, 2020
Merged

I18n backport 1.3.0 strings #5247

merged 19 commits into from
May 12, 2020

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

Backports #5243 - i18n changes for 1.3.0 release

Testing

rmol added 19 commits May 11, 2020 13:26
contributors:
  Thalia Rahme
  erinm

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 3a54c43)
contributors:
  Joan Montané
  John Smith

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit c55c01e)
contributors:
  1000101
  michaela-bot

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 4670ee8)
contributors:
  John Hensley
  Robin Schubert

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit a83d3cc)
contributors:
  Adrian
  Dimitris Maroulidis

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 29ea96f)
contributors:
  Zuhualime Akoochimoya
  erinm

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 6f473de)
contributors:
  AO Localization Lab

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 30701c0)
contributors:
  Drashti

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit e35eced)
contributors:
  Oktavia
  Sveinn í Felli

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit af701b5)
contributors:
  Claudio Arseni

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit cf83c8c)
contributors:
  Øyvind Bye Skille

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 4496abe)
contributors:
  Meteor0id
  kwadronaut

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 05755e8)
contributors:
  Andrey

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 451b3e6)
contributors:
  1000101

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 9abff29)
contributors:
  Jonas Waga
  erinm

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 669611f)
contributors:
  Kaya Zeren
  Volkan
  tekrei

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit c594972)
contributors:
  Chi-Hsun Tsai
  Kushal Das

updated from:
  repo: https://github.com/freedomofpress/securedrop-i18n
  revision: 28f8f89

(cherry picked from commit 995bab6)
Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

@emkll
Copy link
Contributor

emkll commented May 12, 2020

Commits for pt_BR (dfd7e7d) and ro (2cf03ed) were not cherry-picked with -x, which references the commit in the develop branch. Otherwise, the commits are the same.

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given 4h CI time for translation tests, let's merge this given the test plan is passing, we will be able to find the commits in develop in context. LGTM:

@emkll emkll merged commit 71aa994 into release/1.3.0 May 12, 2020
@emkll emkll deleted the i18n-backport-1.3.0-strings branch May 12, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants