-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translations for 1.3.0 #5243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributors: Thalia Rahme erinm updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Joan Montané John Smith updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: 1000101 michaela-bot updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: John Hensley Robin Schubert updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Adrian Dimitris Maroulidis updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Zuhualime Akoochimoya erinm updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: AO Localization Lab updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Drashti updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Oktavia Sveinn í Felli updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Claudio Arseni updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Øyvind Bye Skille updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Meteor0id kwadronaut updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: communiaa updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: robbpa updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Andrey updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: 1000101 updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Jonas Waga erinm updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Kaya Zeren Volkan tekrei updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
contributors: Chi-Hsun Tsai Kushal Das updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 28f8f89
zenmonkeykstop
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Followed test plan with no issues (except 3 false positives on
important
as French also triggers it). - Completed visual review of diff. No code injections spotted.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Updates translations for 1.3.0.
Testing
For each supported language, check that each of the 15 source strings changed for 1.3.0 has a plausible-looking translation.
Check out this branch (
i18n-merge-1.3.0
), then runsecuredrop/bin/dev-shell ./i18n_tool.py --verbose translate-messages --compile
to create the.mo
files.Then save this script as
check_130_translations.py
:check_130_translations.py
When run with the translations directory as its only argument (e.g.
python3 check_130_translations.py securedrop/translations
, from the root of your working copy), you should see the 15 strings translated for each supported language, with no unexpected markup (that doesn't match the source string) or other suspicious content in the translated strings. There will be two warnings of possibly missing translations, as "important" is the same word in Catalan and Romanian.Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development containerIf you made non-trivial code changes: