Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n merge #4187

Merged
merged 35 commits into from
Feb 26, 2019
Merged

I18n merge #4187

merged 35 commits into from
Feb 26, 2019

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Feb 25, 2019

Status

Ready for review.

Description of Changes

New translations for 0.12.0 release.

Testing

How should the reviewer test this PR?
Write out any special testing steps here.

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@kushaldas kushaldas changed the title [WIP] I18n merge (DO NOT MERGE) I18n merge Feb 26, 2019
kushaldas and others added 24 commits February 27, 2019 00:16
localizers: robbpa, Jobava, Weblate, Kushal Das, Loic Dachary

https://github.com/freedomofpress/securedrop-i18n
copied from 9f8dc24
localizers: Kaya Zeren, Kushal Das, Volkan, tekrei

https://github.com/freedomofpress/securedrop-i18n
copied from 9f8dc24
localizers: Jonas Franzén, Kushal Das, Allan Nordhøy

https://github.com/freedomofpress/securedrop-i18n
copied from c988148
localizers: Ahmed Essam, A. Nonymous, erinm, ButterflyOfFire, Kushal Das, Ahmad Gharbeia

https://github.com/freedomofpress/securedrop-i18n
copied from c988148
localizers: Kushal Das, Zuhualime Akoochimoya, erinm

https://github.com/freedomofpress/securedrop-i18n
copied from c988148
localizers: Øyvind Bye Skille, Kushal Das, Allan Nordhøy

https://github.com/freedomofpress/securedrop-i18n
copied from c988148
@eloquence
Copy link
Member

I still don't see actual Icelandic strings beyond the desktop messages, that is, there is no is directory under securedrop/translations. Is that intentional?

@redshiftzero
Copy link
Contributor

@eloquence nope that is not intentional, will investigate and append here in a bit

localizers: Oktavia, Jennifer Helsby, Kushal Das, Sveinn í Felli

https://github.com/freedomofpress/securedrop-i18n
copied from e57cf47
@heartsucker heartsucker merged commit df44ce1 into develop Feb 26, 2019
@heartsucker heartsucker deleted the i18n-merge branch February 26, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants